feat(KNO-5026): Add tenant inline identification #32
Conversation
| @@ -56,6 +55,26 @@ public UpdateSchedulesRequestBuilder addActor(String actor) { | |||
| return this; | |||
| } | |||
|
|
|||
| public UpdateSchedulesRequestBuilder addActor(Map<String, Object> actor) { | |||
There was a problem hiding this comment.
I think this is something we missed, as actors can also be passed as a map full of custom properties.
francoborr
changed the title
| @@ -28,7 +27,7 @@ public class CreateSchedulesRequest { | |||
| List<Object> recipients; | |||
| List<ScheduleRepeat> repeats; | |||
| Object actor; | |||
| String tenant; | |||
| Object tenant; | |||
There was a problem hiding this comment.
Does this type incorporate a string or a Tenant object then? Object is like any in typescript, right?
There was a problem hiding this comment.
So for both actor and tenant we support the following values:
- A simple
string - A more complex object with properties
So answering to your question: Yes from my understanding Object works as a generic type (and can be a string as well), so it covers the possible values we may have IMO.
| .tenant(TenantRecipientIdentifier.builder() | ||
| .id("tenant-id") |
There was a problem hiding this comment.
Seeing this in use, I don't think we need this builder as all we're ever doing is building a string?
There was a problem hiding this comment.
So there are three posible values for a tenant:
- A raw string referencing the tenant ID
- An object containing only an ID property(for this we use the
TenantRecipientIdentifierbuilder we are talking about) - An object with more properties
So from my understanding we need this builder for the second case, as I want to be clear a tenant can be an object with a simple ID field without more properties.
There was a problem hiding this comment.
your example of (2) is wholly covered under (3). We only had this builder for objects because you can explicitly build an object reference that needs an id and a collection, so the builder was a convenience method to build that elegantly, without needing to pass a map.
For tenants, the interface should just be either a string, or a map.
There was a problem hiding this comment.
OK got it, I'll remove the builder.
Updates the following java classes: WorkflowTriggerRequest, UpdateSchedulesRequest and CreateSchedulesRequest
Until now the
tenantproperty in these classes was a simple string, but from now on the property can have one of the following values:TenantRecipientIdentifier({"id": "tenant-id"})