Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exec readiness probes for sidecar containers #15773

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FloMedja
Copy link

Fixes #15484

Proposed Changes

Delegate the exec readiness probes to kubernetes for sidecar containers. The controller previsouly return an error when a exec readiness probes is defined on a sidecar container. We now support the exec readiness probes for all the containers.

Release Note

Support exec readiness probes for sidecar containers

Copy link

linux-foundation-easycla bot commented Feb 12, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FloMedja
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

knative-prow bot commented Feb 12, 2025

Welcome @FloMedja! It looks like this is your first PR to knative/serving 🎉

Copy link

knative-prow bot commented Feb 12, 2025

Hi @FloMedja. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto February 12, 2025 16:07
@FloMedja FloMedja marked this pull request as draft February 12, 2025 16:11
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@FloMedja FloMedja force-pushed the support-exec-readiness-probes-for-sidecar-containers branch from c1d3397 to c14663c Compare February 12, 2025 16:13
@FloMedja FloMedja marked this pull request as ready for review February 12, 2025 16:18
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@knative-prow knative-prow bot requested a review from dprotaso February 12, 2025 16:18
@dprotaso
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.82%. Comparing base (4994b59) to head (a2f121f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15773      +/-   ##
==========================================
- Coverage   80.83%   80.82%   -0.02%     
==========================================
  Files         222      222              
  Lines       18075    18078       +3     
==========================================
  Hits        14611    14611              
- Misses       3094     3096       +2     
- Partials      370      371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FloMedja
Copy link
Author

@dprotaso @skonto A e2e test failed for v1.30.x but succeeded for v1.31.x. I don't see an option to rerun the test. How can I rerun it ?

Also I see a MR removing the support for v.1.30.x, was there some issues with this version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support exec readinessProbes for sidecar serving containers
2 participants