-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support exec readiness probes for sidecar containers #15773
base: main
Are you sure you want to change the base?
Support exec readiness probes for sidecar containers #15773
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FloMedja The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @FloMedja! It looks like this is your first PR to knative/serving 🎉 |
Hi @FloMedja. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c1d3397
to
c14663c
Compare
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15773 +/- ##
==========================================
- Coverage 80.83% 80.82% -0.02%
==========================================
Files 222 222
Lines 18075 18078 +3
==========================================
Hits 14611 14611
- Misses 3094 3096 +2
- Partials 370 371 +1 ☔ View full report in Codecov by Sentry. |
Fixes #15484
Proposed Changes
Delegate the
exec readiness
probes to kubernetes for sidecar containers. The controller previsouly return an error when aexec readiness probes
is defined on a sidecar container. We now support theexec readiness probes
for all the containers.Release Note