Incorrect Value Mapping

[pqhf5kd]

The 'New value' being pulled from FHRS isn't always correctly mapped. (In fact, I haven't noticed a single correct instance)

[kmpoppe]

The problem is that the AddressLines 1 through 4 are out of order in the FHRS response - you can clearly see in your examples that "NEW MILTON" is once returned in another entry than in the other two examples - only the postcode is it's own field and therefore must be in the right place. I just guessed from what I saw in my tests around London, but it seems that other authorities just list the entries differently.

I need to try to figure out a way to guess the address better.

[pqhf5kd]

I figured that might be the case :)

[pqhf5kd]

Could the value mapping be saved/loaded by the user? The user could drag and drop the values in the merge window and then save the config for that LA?

[kmpoppe]

I hadn't thought about that being a Local Authority-kind of thing ... but that might be a brill idea. Lemme see if I can manage that.

[osm-spiregrain]

More evidence - this time from LB Newham.

[kmpoppe]

@pqhf5kd @osm-spiregrain I have built a pre-release (https://github.com/kmpoppe/fhrsPlugin/releases/tag/0.2.1) that will allow you to select which Tag you want to assign to which AddressLine. Would you care to test that out before I start building some contraption for saving that matches somewhere?
Thanks!

[osm-spiregrain]

The new feature seems to wok well - many thanks for working on it. It is let down slightly be the way FHRS info is structured. I would propose- 1. Make it possible to assign FHRS values to addr:suburb. 2. Make it possible to parse out housenumbers. I found many examples where the FHRS address data has "53 Jones Road" in a since field, and ideally we'd place in in addr:housenumber and addr:street separately. I realise that might be a big change - so if it's not possible, don't worry. The fact that the user can see the "53 Jones Road" field and can edit the data means that it just takes a tiny bit more manual effort. 3. I wonder if anything can be done to make the drop-down lists of OSM tags more discoverable? It took me a moment, and I knew what sort of thing to look for. As a side issue, I did have one crash when using "Search surrounding FHRS authorities" on a node with no relevant tags - screenshot below

…

--- Ken Kilfedder ***@***.***

On Fri, 16 Apr 2021, at 5:52 AM, Kai Michael Poppe wrote: @pqhf5kd <https://github.com/pqhf5kd> @osm-spiregrain <https://github.com/osm-spiregrain> I have built a pre-release (https://github.com/kmpoppe/fhrsPlugin/releases/tag/0.2.1) that will allow you to select which Tag you want to assign to which AddressLine. Would you care to test that out before I start building some contraption to saving that matching somewhere? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFCYYAHIN2STY6PNDM54RTTI67BFANCNFSM4OJ4ISKQ>.