Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable To Search By Name #8

Closed
pqhf5kd opened this issue Jun 27, 2020 · 6 comments
Closed

Unable To Search By Name #8

pqhf5kd opened this issue Jun 27, 2020 · 6 comments

Comments

@pqhf5kd
Copy link

pqhf5kd commented Jun 27, 2020

The menu "Search entry" looks up establishments in FHRS using this three options in order:

name and address
address only
name only

image

Is searching by name disabled while you work on #4 ?

If #7 can be fixed and we're able to search by name, this plugin would even more useful allowing us to population address and FHRS info at once.

Thanks :)

@kmpoppe
Copy link
Owner

kmpoppe commented Jun 27, 2020

No, searching by name isn't disabled per se, there's just something wrong in my logic to allow searching without an address... Will need to figure out what went wrong. Which node/way did you select to reach this message?

@pqhf5kd
Copy link
Author

pqhf5kd commented Jun 27, 2020

Here are two examples:

  • 6695231888
  • 6691214599

@kmpoppe
Copy link
Owner

kmpoppe commented Jun 27, 2020

I changed the logic to be name & address OR address. Name only will not work consistently, so this is not an option for the time being ;-) ... And of course the plugin now asks for an address if there's none in the object.

@kmpoppe
Copy link
Owner

kmpoppe commented Jun 27, 2020

When using the Node 6691214599 and entering "station road new milton" when prompted, you get this result to merge:
image
I guess this now works as intended :-D
Will publish 0.1.5 in a few minutes for you.
BTW: I can't find Dukes Station Cafe, I guess it has a new name now?

@pqhf5kd
Copy link
Author

pqhf5kd commented Jun 28, 2020

This works great but is it possible to cache the last entry in the 'Input' window? That way a user can go along a street or through a whole town without having to type, or paste, the input.

@pqhf5kd
Copy link
Author

pqhf5kd commented Jun 28, 2020

@kmpoppe I thought that commenting would reopen this but I guess not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants