Correctly use transformed object

Signed-off-by: Tamal Saha <[email protected]>
kmodules · Jan 8, 2025 · 38fba91 · 38fba91
1 parent 094da47
commit 38fba91
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/client/client.go b/client/client.go
@@ -143,8 +143,7 @@ func CreateOrPatchE(ctx context.Context, c client.Client, obj client.Object, tra
 
 func CreateOrPatch(ctx context.Context, c client.Client, obj client.Object, transform TransformFunc, opts ...client.PatchOption) (kutil.VerbType, error) {
 	return CreateOrPatchE(ctx, c, obj, func(obj client.Object, createOp bool) (client.Object, error) {
-		transform(obj, createOp)
-		return obj, nil
+		return transform(obj, createOp), nil
 	}, opts...)
 }
 
@@ -188,8 +187,7 @@ func PatchE(ctx context.Context, c client.Client, obj client.Object, transform P
 
 func Patch(ctx context.Context, c client.Client, obj client.Object, transform PatchFunc, opts ...client.PatchOption) (kutil.VerbType, error) {
 	return PatchE(ctx, c, obj, func(obj client.Object) (client.Object, error) {
-		transform(obj)
-		return obj, nil
+		return transform(obj), nil
 	}, opts...)
 }
 
@@ -232,8 +230,7 @@ func PatchStatusE(ctx context.Context, c client.Client, obj client.Object, trans
 
 func PatchStatus(ctx context.Context, c client.Client, obj client.Object, transform PatchFunc, opts ...client.SubResourcePatchOption) (kutil.VerbType, error) {
 	return PatchStatusE(ctx, c, obj, func(obj client.Object) (client.Object, error) {
-		transform(obj)
-		return obj, nil
+		return transform(obj), nil
 	}, opts...)
 }