Update waypoint install #99
Open
+86
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhonghu Xu <[email protected]>
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Zhonghu Xu <[email protected]>
|
/assign @YaoZengzeng |
YaoZengzeng
reviewed
Dec 25, 2024
| @@ -11,7 +11,7 @@ type: docs | |||
|
|
|||
| --- | |||
|
|
|||
| To try capabilities of Kmesh L7, this is the basic doc to install waypoint. | |||
| If you want to make use of kmesh L7 features, this is the prerequisites to install waypoint. | |||
There was a problem hiding this comment.
Suggested change
| If you want to make use of kmesh L7 features, this is the prerequisites to install waypoint. | |
| If you want to make use of Kmesh L7 features, this is the prerequisites to install waypoint. |
YaoZengzeng
reviewed
Dec 25, 2024
|
|
||
| ***NOTE: There are breaking changes in waypoint capture mode between istio 1.22 and istio 1.21, so the following commands need to be run on at least istio 1.22.*** | ||
| Deploy a waypoint `reviews-svc-waypoint` for service `reviews`, so any traffic to `reviews` from a client managed by kmesh will be mediated by the waypoint proxy |
There was a problem hiding this comment.
Suggested change
| Deploy a waypoint `reviews-svc-waypoint` for service `reviews`, so any traffic to `reviews` from a client managed by kmesh will be mediated by the waypoint proxy | |
| Deploy a waypoint `reviews-svc-waypoint` for service `reviews`, so any traffic to `reviews` from a client managed by Kmesh will be mediated by the waypoint proxy |
YaoZengzeng
reviewed
Dec 25, 2024
|
|
||
| #### Install waypoint in service granularity: | ||
| To enable a namespace, service or Pod to use a waypoint, add the `istio.io/use-waypoint` label with a value of the waypoint name. |
There was a problem hiding this comment.
Suggested change
| To enable a namespace, service or Pod to use a waypoint, add the `istio.io/use-waypoint` label with a value of the waypoint name. | |
| To enable a namespace, service or pod to use a waypoint, add the `istio.io/use-waypoint` label with a value of the waypoint name. |
YaoZengzeng
reviewed
Dec 25, 2024
|
|
||
| ***NOTE: Also need to replace the original image of waypoint with the Kmesh customized image.*** | ||
| Deploy a waypoint for the `default` with default name `waypoint`. By specifying `--enroll-namespace`, the namespace will be labeled with `istio.io/use-waypoint=waypoint` |
There was a problem hiding this comment.
Suggested change
| Deploy a waypoint for the `default` with default name `waypoint`. By specifying `--enroll-namespace`, the namespace will be labeled with `istio.io/use-waypoint=waypoint` | |
| Deploy a waypoint for the `default` namespace with default name `waypoint`. By specifying `--enroll-namespace`, the namespace will be labeled with `istio.io/use-waypoint=waypoint` |
YaoZengzeng
reviewed
Dec 25, 2024
| pod/reviews-v2-5b667bcbf8-spnnh labeled | ||
| ``` | ||
|
|
||
| ***NOTE: Also need to replace the original image of waypoint with the Kmesh customized image.*** | ||
| ***NOTE: If you need to replace the original image of waypoint with the Kmesh customized image.*** |
There was a problem hiding this comment.
No more image replacement operations are required.
There was a problem hiding this comment.
nope, currently if user build kmeshctl locally, it could generate yaml with :vv0.0.0-master image
Signed-off-by: Zhonghu Xu <[email protected]>
|
/assign @nlgwcy |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YaoZengzeng The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zhonghu Xu <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Zhonghu Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kmesh waypoint subcommand is added after v0.5