feat: hashdict_finalize #496
Open
+225
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/hashdict_finalize
branch
from
bae527b to
064a9ac
Compare
cairo/src/utils/dict.cairo
Outdated
| @@ -136,3 +137,83 @@ func hashdict_write{poseidon_ptr: PoseidonBuiltin*, dict_ptr: DictAccess*}( | |||
| let dict_ptr = dict_ptr + DictAccess.SIZE; | |||
| return (); | |||
| } | |||
|
|
|||
| func hashdict_finalize{range_check_ptr}( | |||
There was a problem hiding this comment.
maybe add some comments to explain the behaviors of merge=FALSE and TRUE
There was a problem hiding this comment.
eventually, I think that this function should be called dict_update, similarly to python dict.update() because it's what it does: updating the value of dict 1 (original_mapping) here with the values of dict 2 (dict_ptr here). For soundness, we need to add a drop: bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #403