Cw/fix mod builtins n0

[ClementWalter]

TITLE

Description

Description of the pull request changes and motivation.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

[github-actions]

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     31.958 s ±  0.081 s    [User: 31.224 s, System: 0.731 s]
  Range (min … max):   31.900 s … 32.015 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     31.823 s ±  0.195 s    [User: 31.111 s, System: 0.709 s]
  Range (min … max):   31.685 s … 31.960 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.01 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     17.708 s ±  0.007 s    [User: 30.997 s, System: 0.810 s]
  Range (min … max):   17.703 s … 17.712 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     17.722 s ±  0.171 s    [User: 30.907 s, System: 0.784 s]
  Range (min … max):   17.601 s … 17.842 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     12.523 s ±  0.312 s    [User: 43.929 s, System: 0.933 s]
  Range (min … max):   12.302 s … 12.743 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     12.331 s ±  0.614 s    [User: 44.162 s, System: 0.939 s]
  Range (min … max):   11.897 s … 12.765 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.02 ± 0.06 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     12.018 s ±  0.012 s    [User: 43.948 s, System: 0.934 s]
  Range (min … max):   12.009 s … 12.026 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     12.210 s ±  0.192 s    [User: 43.362 s, System: 0.944 s]
  Range (min … max):   12.074 s … 12.346 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     11.829 s ±  0.055 s    [User: 44.495 s, System: 0.942 s]
  Range (min … max):   11.790 s … 11.867 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     11.899 s ±  0.115 s    [User: 44.528 s, System: 0.946 s]
  Range (min … max):   11.818 s … 11.980 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     11.761 s ±  0.107 s    [User: 44.714 s, System: 1.052 s]
  Range (min … max):   11.685 s … 11.837 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     12.033 s ±  0.388 s    [User: 44.483 s, System: 1.029 s]
  Range (min … max):   11.759 s … 12.307 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.02 ± 0.03 times faster than hyper_threading_pr threads: 16

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.512 ± 0.034	2.463	2.557	1.00
head big_factorial	2.531 ± 0.068	2.452	2.645	1.01 ± 0.03

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	2.437 ± 0.028	2.392	2.463	1.01 ± 0.02
head big_fibonacci	2.424 ± 0.023	2.396	2.461	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	9.242 ± 0.136	8.995	9.452	1.01 ± 0.02
head blake2s_integration_benchmark	9.167 ± 0.106	8.987	9.310	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.580 ± 0.049	2.531	2.684	1.00
head compare_arrays_200000	2.611 ± 0.075	2.543	2.811	1.01 ± 0.04

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.702 ± 0.049	1.667	1.838	1.00
head dict_integration_benchmark	1.708 ± 0.014	1.681	1.731	1.00 ± 0.03

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.427 ± 0.016	1.406	1.453	1.00
head field_arithmetic_get_square_benchmark	1.446 ± 0.022	1.413	1.498	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	9.280 ± 0.178	9.066	9.707	1.01 ± 0.02
head integration_builtins	9.196 ± 0.144	9.076	9.554	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	9.478 ± 0.098	9.347	9.621	1.00
head keccak_integration_benchmark	9.505 ± 0.120	9.311	9.690	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.597 ± 0.037	2.531	2.659	1.00 ± 0.02
head linear_search	2.592 ± 0.048	2.532	2.677	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.759 ± 0.035	1.722	1.826	1.00
head math_cmp_and_pow_integration_benchmark	1.760 ± 0.019	1.737	1.793	1.00 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.699 ± 0.017	1.680	1.736	1.00
head math_integration_benchmark	1.726 ± 0.037	1.688	1.814	1.02 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.425 ± 0.022	1.402	1.475	1.00
head memory_integration_benchmark	1.443 ± 0.017	1.421	1.466	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.814 ± 0.023	1.790	1.858	1.00
head operations_with_data_structures_benchmarks	1.836 ± 0.027	1.810	1.881	1.01 ± 0.02

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	585.0 ± 4.1	577.0	589.3	1.00 ± 0.01
head pedersen	584.5 ± 4.8	579.7	592.8	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base poseidon_integration_benchmark	712.2 ± 24.9	686.2	758.7	1.01 ± 0.04
head poseidon_integration_benchmark	702.5 ± 10.6	686.2	722.0	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	2.063 ± 0.038	2.043	2.168	1.00
head secp_integration_benchmark	2.084 ± 0.021	2.052	2.120	1.01 ± 0.02

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base set_integration_benchmark	715.3 ± 19.6	695.6	758.9	1.05 ± 0.03
head set_integration_benchmark	683.2 ± 5.9	676.7	691.2	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	5.022 ± 0.044	4.978	5.104	1.00
head uint256_integration_benchmark	5.090 ± 0.083	4.991	5.285	1.01 ± 0.02