fix: race condition with external binary download (electron#64)

kjvenalainen · Jan 23, 2020 · 42404dc · 42404dc
1 parent 2d34194
commit 42404dc
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/e-init.js b/src/e-init.js
@@ -184,12 +184,16 @@ try {
   const opts = { stdio: 'inherit' };
   childProcess.execFileSync('node', [e, 'use', name], opts);
 
+  // (maybe) run sync to ensure external binaries are downloaded
+  if (program.bootstrap) {
+    childProcess.execFileSync('node', [e, 'sync', '-v'], opts);
+  }
+
   // maybe authenticate with Goma
   if (config.goma) goma.auth(config.root);
 
-  // maybe bootstrap
+  // (maybe) build Electron
   if (program.bootstrap) {
-    childProcess.execFileSync('node', [e, 'sync', '-v'], opts);
     childProcess.execFileSync('node', [e, 'build'], opts);
   }
 } catch (e) {