Add support for Ruby 3.4 #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses warnings when running the gem in a Ruby 3.4 app, which has frozen string literals warning enabled by default. Ruby 3.5 will have frozen string literals turned on by default. Signed-off-by: Clément Joubert <[email protected]>
With a very large file, we avoid duplicating the whole string just to add the wrapper at the begging then at the end. I think this should save a lot on memory allocations and garbage collections on large sitemaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates XML generation to be compatible with Ruby 3.4's default frozen string literals and optimizes string handling for better performance.
It resolves warnings when running the gem in a Ruby 3.4 application, where frozen string literals are enabled by default, and prepares for Ruby 3.5's upcoming default behavior. This change anticipates
frozen_string_literalsbecoming the default in Ruby 3.5.It expands test coverage by adding Ruby 3.4 to the test matrix to ensure compatibility with the latest Ruby version.
It optimizes memory usage in XML generation by preventing unnecessary string duplication when writing. It eliminates the need to duplicate entire strings when adding wrappers at the beginning and end, significantly reducing memory allocations and garbage collections, which is particularly beneficial for generating large sitemaps.