Enable sending of breadcrumb data #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveldedik
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Thank you, it looks good and also adds remaining functionality implemented in #43
Can you also please fix the failing pipeline? It would also be nice to add tests.
rdarcy1
force-pushed
the
enable-breadcrumb-data
branch
from
f62a549 to
5ae6cf7
Compare
|
Thanks, tox is passing locally so hopefully pipelines are fixed (don't think they'll run automatically on GitHub as I'm not a contributor). Added some tests, let me know if they're OK. |
paveldedik
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #43
Sends breadcrumb data from
event_dictwith user-editable exclusion list.