Feature/4 crud and dtos for event entity #7
Conversation
apps/backend/.eslintrc.js
Outdated
| @@ -16,5 +16,6 @@ module.exports = { | |||
| '@typescript-eslint/no-empty-function': 'off', | |||
| '@typescript-eslint/no-extra-semi': 'off', | |||
| '@typescript-eslint/no-unused-vars': 'error', | |||
| 'ordered-imports': [true, { 'grouped-imports': false }], //disable anoying empty line between import groups | |||
There was a problem hiding this comment.
I guess we should use 2 instead of true and maybe 0 instead of false
There was a problem hiding this comment.
rather deleted it because it caused more problems and is not as annoying as I thought before
| @IsDate() | ||
| startDate: Date; | ||
|
|
||
| @IsDate() | ||
| endDate: Date; |
There was a problem hiding this comment.
we will probably need @IsDateString() here, IsDate expects a Date object, but wie'll get a string
There was a problem hiding this comment.
also, it'd be cool to validate that endDate is after startDate. You probably have to create a custom decorator for that, it's a great task if you have the time
| } | ||
|
|
||
| @Get(':id') | ||
| findOne(@Param('id') id: string) { |
There was a problem hiding this comment.
we should validate the id here. In the course, we used ParseIntPipe, but that's not going to work here since we don't use number based ID.s Instead take a look at ParseUUIDPipe
Solution for #4