fix drink counting #47
Conversation
murtagh27
requested review from
a team,
Tschonti,
LeventeFarkashazi,
pem00 and
VarMattew
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
nice work, but we have to think one thing over:
The user is creating drinkActions here, and drinkActions have price and millilitre properties (the drink entity itself contains neither of these infos (currently)). So selecting two beers doesn't make sense right now, instead the user should be able to specify the amount consumed in millilitres.
Or we could change how we store drinks, and store a defaultVolume with each, then this could work
There was a problem hiding this comment.
I tried running on my machine, and event creation works without problems, as long as you don't send any drinkactions. So maybe it was just a migration error all along.
I think it's best to leave the stuff with the drinkAction dialog for later, we can merge this once the other small issues have been addressed
|
just remove the console logs and vercel will be happy as well |
No description provided.