Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create event form created #46

Merged
merged 1 commit into from
Aug 20, 2024
Merged

create event form created #46

merged 1 commit into from
Aug 20, 2024

Conversation

murtagh27
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
be-alcoholic-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 9:24pm

@murtagh27 murtagh27 requested review from a team, Tschonti, LeventeFarkashazi, pem00 and VarMattew and removed request for a team August 19, 2024 21:25
@murtagh27 murtagh27 self-assigned this Aug 19, 2024
@murtagh27 murtagh27 linked an issue Aug 19, 2024 that may be closed by this pull request
Create event form initial design #42
Closed
4 tasks
@murtagh27 murtagh27 removed their assignment Aug 19, 2024
Tschonti
Tschonti reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@Tschonti Tschonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done! Later it'll be better if we use the shadcn components (for buttons, dialog), so we don't have apply the same styling (for the color and hover effect) everywhere, just once. But those components are not on this branch, so it's okay for now.

@murtagh27 murtagh27 merged commit ec5dae5 into main Aug 20, 2024
5 checks passed
@murtagh27 murtagh27 deleted the create-event-form-frontend branch August 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tschonti Tschonti Tschonti approved these changes

@LeventeFarkashazi LeventeFarkashazi Awaiting requested review from LeventeFarkashazi LeventeFarkashazi was automatically assigned from kir-dev/pod-lima

@pem00 pem00 Awaiting requested review from pem00 pem00 was automatically assigned from kir-dev/pod-lima

@VarMattew VarMattew Awaiting requested review from VarMattew VarMattew was automatically assigned from kir-dev/pod-lima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create event form initial design
2 participants
@murtagh27 @Tschonti