16. Modify create event endpoint to accept a list of DrinkActions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtagh27
requested review from
a team,
Tschonti,
LeventeFarkashazi,
pem00 and
VarMattew
and removed request for
a team
Tschonti
requested changes
Jul 24, 2024
Tschonti
requested changes
Aug 5, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tschonti
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Thanks for the fixes, just one last change request: 😄
The automatic build failed because the drinkActions were connected to the users in another PR, and with that change, you'll have to provide a user in lines 23-26 in events.service.ts. If you update your main branch, then merge the main branch into your branch, you'll see the same error locally. Please merge main, connect the user to the new drinkAction (similar to how you connected the drink) and then this will be ready to go.
Tschonti
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.