Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25 bac query endpoint #31

Merged
merged 10 commits into from
Aug 1, 2024
Merged

25 bac query endpoint #31

merged 10 commits into from
Aug 1, 2024

Conversation

VarMattew
Copy link
Contributor

No description provided.

@VarMattew VarMattew requested review from a team, Tschonti, LeventeFarkashazi, murtagh27 and pem00 and removed request for a team July 22, 2024 09:54
@VarMattew VarMattew linked an issue Jul 22, 2024 that may be closed by this pull request
Create an endpoint where the blood alcohol level can be queried #25
Closed
3 tasks
Tschonti
Tschonti requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@Tschonti Tschonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few notes/suggestions, but great solution otherwise

apps/backend/src/users/users.controller.ts Outdated Show resolved Hide resolved
apps/backend/src/users/users.service.ts Outdated Show resolved Hide resolved
apps/backend/src/users/users.service.ts Show resolved Hide resolved
apps/backend/src/users/users.service.ts Outdated Show resolved Hide resolved
apps/backend/src/users/users.service.ts Outdated Show resolved Hide resolved
@VarMattew VarMattew requested a review from Tschonti July 27, 2024 18:02
Tschonti
Tschonti approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Tschonti Tschonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff 👌

@VarMattew VarMattew merged commit 784078b into main Aug 1, 2024
3 checks passed
@VarMattew VarMattew deleted the 25-bac-query-endpoint branch August 1, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tschonti Tschonti Tschonti approved these changes

@LeventeFarkashazi LeventeFarkashazi Awaiting requested review from LeventeFarkashazi LeventeFarkashazi was automatically assigned from kir-dev/pod-lima

@murtagh27 murtagh27 Awaiting requested review from murtagh27 murtagh27 was automatically assigned from kir-dev/pod-lima

@pem00 pem00 Awaiting requested review from pem00 pem00 was automatically assigned from kir-dev/pod-lima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an endpoint where the blood alcohol level can be queried
2 participants
@VarMattew @Tschonti