Drink resource #13
Merged
Drink resource #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tschonti
requested review from
a team,
LeventeFarkashazi,
murtagh27,
pem00 and
VarMattew
and removed request for
a team
This was
linked to
issues
May 17, 2024
Closed
| @IsBoolean() | ||
| custom: boolean; | ||
|
|
||
| @IsString() |
There was a problem hiding this comment.
I think we could add examples for the optional fields too.
|
|
||
| /** | ||
| * Name of the drink | ||
| * @example Soproni meggy |
There was a problem hiding this comment.
The swagger default values don't work, the example string values should be between apostrophes.
/**
- Name of the drink
- @example 'Soproni meggy'
*/
LeventeFarkashazi
requested changes
May 18, 2024
LeventeFarkashazi
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drink DTOs, controller and service