Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: sev crate to 3.1.1 #52

Merged
merged 2 commits into from
May 14, 2024
Merged

bump: sev crate to 3.1.1 #52

merged 2 commits into from
May 14, 2024

Conversation

wobito
Copy link
Contributor

@wobito wobito commented May 2, 2024

Bump SEV crate

This PR will bump the SEV crate to 3.1.1 for use within the github.com/confidential-containers/trustee and github.com/confidential-containers/guest-compoments repos

@wobito wobito mentioned this pull request May 13, 2024
Merged
mkulke
mkulke reviewed May 14, 2024
View reviewed changes
Copy link
Member

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general that should work, can you do the following?

  • do a drive-by fix for the lint
  • run "cargo semver-check" to tell if there's a breaking change, since we might expose some sev types
  • bump the version accordingly (patch for non-breaking, minor for breaking).

@wobito
Copy link
Contributor Author

wobito commented May 14, 2024

Awesome! Thanks for the review will tackle this today!

@wobito
update: version and fix lint
ec8946c 
Signed-off-by: Adrian Wobito <[email protected]>
@wobito
Copy link
Contributor Author

wobito commented May 14, 2024

Results from cargo semver-checks

Parsing az-cvm-vtpm v0.5.2 (current)
      Parsed [   9.601s] (current)
     Parsing az-cvm-vtpm v0.5.2 (baseline)
      Parsed [   9.377s] (baseline)
    Checking az-cvm-vtpm v0.5.2 -> v0.5.2 (no change)
     Checked [   0.007s] 72 checks; 72 passed, 0 unnecessary
    Finished [  18.995s] az-cvm-vtpm

@wobito wobito requested a review from mkulke May 14, 2024 15:16
mkulke
mkulke approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks, I'll publish a release.

@mkulke mkulke merged commit 53d64b8 into kinvolk:main May 14, 2024
1 check passed
@mkulke
Copy link
Member

mkulke commented May 14, 2024

lgtm. thanks, I'll publish a release.

@wobito crates have been published

@wobito wobito mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkulke mkulke mkulke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wobito @mkulke