Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers path to tsconfig #394

Merged

Conversation

ferhoyos
Copy link
Collaborator

@ferhoyos ferhoyos commented Nov 5, 2024

Describe the change

Add the helpers path to the tsconfig.json file to fix the OSSMC build.

Ignore the changes within the plugin/cypress/kiali and plugin/src/kiali folders since they are copied from the Kiali repo.

Steps to test the PR

Verify that OSSMC builds successfully.

Automation testing

N/A

Kiali frontend source originated from:
* git ref:    master
* git commit: 9bc49a5491c47889b7663e00b5c2c9b54eb49e92
* GitHub URL: https://github.com/kiali/kiali/tree/9bc49a5491c47889b7663e00b5c2c9b54eb49e92/frontend/src

Signed-off-by: Fernando Hoyos <[email protected]>
@ferhoyos ferhoyos added the test: n/a PR does not need test additions or updates label Nov 5, 2024
@ferhoyos ferhoyos requested a review from nrfox November 5, 2024 12:03
@ferhoyos ferhoyos self-assigned this Nov 5, 2024
@ferhoyos
Copy link
Collaborator Author

ferhoyos commented Nov 5, 2024

@jshaughn jshaughn requested review from jshaughn and removed request for nrfox November 5, 2024 14:40
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@jshaughn jshaughn merged commit e303cc0 into kiali:main Nov 5, 2024
2 checks passed
@ferhoyos ferhoyos deleted the kiali-frontend-update-2024-11-05-11-08-23 branch December 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

2 participants