Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable graph tests in OSSMC #389

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

ferhoyos
Copy link
Collaborator

@ferhoyos ferhoyos commented Oct 22, 2024

Describe the change

Enable the patternfly cypress graph tests in OSSMC

Bonus:

  • Change the order of initializing the Kiali listener due to a small navigation issue detected by one of the graph Cypress tests. However, the test is still failing, so I had to skip it in OSSMC (see Enable graph tests in OSSMC kiali#7846)
  • Load the pf-icons CSS in OSSMC to display the graph icons.

Before:

image

After:

image

Steps to test the PR

Verify that the CI tests for OSSMC are successful

@ferhoyos ferhoyos added the test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation ) label Oct 22, 2024
@ferhoyos ferhoyos self-assigned this Oct 22, 2024
@ferhoyos ferhoyos force-pushed the enable-pft-cypress-tests branch from 6715e3d to 51aa0e6 Compare October 23, 2024 08:33
@ferhoyos
Copy link
Collaborator Author

Copy link
Contributor

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ferhoyos ferhoyos merged commit ce04828 into kiali:main Oct 24, 2024
2 checks passed
@ferhoyos ferhoyos deleted the enable-pft-cypress-tests branch October 24, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation )
Projects
Development

Successfully merging this pull request may close these issues.

2 participants