Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cypress test hooks #382

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

ferhoyos
Copy link
Collaborator

Describe the change

Add missing cypress test hooks that makes some sidecar injection test failed.

Steps to test the PR

Verify that CI tests pass

@ferhoyos ferhoyos self-assigned this Sep 26, 2024
@ferhoyos ferhoyos marked this pull request as ready for review September 26, 2024 15:51
@ferhoyos ferhoyos added the test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation ) label Sep 26, 2024
Copy link
Contributor

@ScriptingShrimp ScriptingShrimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I thought this might affect regular kiali/kiali hooks, but we use different file:
/cypress/integration/openshift/common/hooks.ts vs /cypress/integration/common/hooks.ts in kiali/kiali

@ferhoyos ferhoyos merged commit 7c374f4 into kiali:main Sep 26, 2024
2 checks passed
@ferhoyos ferhoyos deleted the missing-test-hooks branch September 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation )
Projects
Development

Successfully merging this pull request may close these issues.

2 participants