Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialize-javascript dependency #378

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ferhoyos
Copy link
Collaborator

Describe the change

Update serialize-javascript dependency to version 6.0.2.

Instead of adding this version to resolutions section, I have updated the parent dependency that import serialize-javascript as it was a bit outdated. This will improve the application's security."

Library updated:

  • @badeball/cypress-cucumber-preprocessor to version 20.1.2.

Breaking changes in the major version do not affect us:

Bonus:

  • Align seed-random version in package.json to download only one version in the application.

Steps to test the PR

Verify that CI tests pass.

Issue reference

https://issues.redhat.com/browse/OSSM-8145

@ferhoyos ferhoyos self-assigned this Sep 17, 2024
@ferhoyos ferhoyos added the test: n/a PR does not need test additions or updates label Sep 17, 2024
@ferhoyos ferhoyos requested a review from aljesusg September 17, 2024 11:33
Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@ferhoyos ferhoyos added the backport needed Issue PRs require backport to versions specified in comments label Sep 17, 2024
@ferhoyos ferhoyos merged commit f7634fc into kiali:main Sep 17, 2024
2 checks passed
@ferhoyos ferhoyos deleted the update-serialize-javascript branch September 17, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needed Issue PRs require backport to versions specified in comments test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

2 participants