Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the config before plugin rendering #377

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ferhoyos
Copy link
Collaborator

Describe the change

This PR loads the plugin config before the initial rendering, ensuring the correct graph (Cytoscape or PatternFly) is loaded the first time.

Steps to test the PR

  1. Navigate to the service or workload details page in the OpenShift console.
  2. Click on the Service Mesh tab
  3. Verify that the minigraph card initially displays a PatternFly graph.

Automation testing

This PR will be covered by kiali/kiali#7713

Issue reference

Fixes #374

@ferhoyos ferhoyos added the test: n/a PR does not need test additions or updates label Sep 13, 2024
@ferhoyos ferhoyos self-assigned this Sep 13, 2024
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@ferhoyos ferhoyos merged commit 06834f6 into kiali:main Sep 13, 2024
2 checks passed
@ferhoyos ferhoyos deleted the 374-plugin-config branch December 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: n/a PR does not need test additions or updates
Projects
Development

Successfully merging this pull request may close these issues.

Minigraph card shows Cytoscape graph the first time
2 participants