Update express dependency (again) #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhoyos
added
the
backport needed
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Update the express dependency to version 4.21.0 to remove version 0.18.0 of the
senddependency.Also, I have updated
path-to-regexpto the latest 1.x release (version 1.9.0), instead of 8.0.0. Both versions meet our requirements, but I believe it is a bit risky to force an upgrade from version 1.x to 8.x.Steps to test the PR
Check that OSSMC works as expected and CI tests pass.
Automation testing
N/A
Issue reference
https://issues.redhat.com/browse/OSSM-8124