Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added favicon in all pages #1315

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

aditya-bhaumik
Copy link
Contributor

Related Issue

Fixes #1281

Description

[Please include a brief description of the changes or features added]
Previously, the favicons were not consistent, but now I have ensured that the favicon is visible on all pages

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.
    <! - [X] - put a cross/X inside [] to check the box -->

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

github-actions bot commented Jul 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for foodies-ordering-website ready!

Name Link
🔨 Latest commit 0582d8e
🔍 Latest deploy log https://app.netlify.com/sites/foodies-ordering-website/deploys/668ec1ac9e395e0008971a35
😎 Deploy Preview https://deploy-preview-1315--foodies-ordering-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aditya-bhaumik
Copy link
Contributor Author

aditya-bhaumik commented Jul 8, 2024

@sunny0625 please review this pull request and merge it

@khushi-joshi-05

@aditya-bhaumik
Copy link
Contributor Author

@khushi-joshi-05 @sunny0625 i have resolved the conflicts please merge this pull request under GSSOC'24

@sunny0625 sunny0625 added gssoc GSSOC'24 issues level1 labels Jul 10, 2024
@sunny0625 sunny0625 merged commit 82b64b0 into khushi-joshi-05:main Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC'24 issues level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] : Ensure Consistent Favicon Across All Website Pages
2 participants