-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump electron from 33.2.1 to 34.0.0 in /packages/scalar-app in the electron-dependency-update group across 1 directory #11
Conversation
Bumps the electron-dependency-update group with 1 update in the /packages/scalar-app directory: [electron](https://github.com/electron/electron). Updates `electron` from 33.2.1 to 34.0.0 - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v33.2.1...v34.0.0) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-major dependency-group: electron-dependency-update ... Signed-off-by: dependabot[bot] <[email protected]>
Reviewer's Guide by SourceryThis pull request updates the electron dependency from version 33.2.1 to 34.0.0 in the /packages/scalar-app directory. This is a major version update, which includes breaking changes, new features, improvements, and fixes. Class diagram showing updated WebFrameMain API changes in Electron 34classDiagram
class WebFrameMain {
+boolean detached
+collectJavaScriptCallStack()
+isDestroyed()
+fromId(processId, frameId)
}
note for WebFrameMain "New properties and methods added in v34.0.0"
Class diagram showing new Session API additions in Electron 34classDiagram
class Session {
+getSharedDictionaryUsageInfo()
+getSharedDictionaryInfo(options)
+clearSharedDictionaryCache()
+clearSharedDictionaryCacheForIsolationKey(options)
}
note for Session "New compression dictionary management APIs added in v34.0.0"
State diagram showing Windows menu bar behavior changes in Electron 34stateDiagram-v2
[*] --> WindowNormal: Window Created
WindowNormal --> WindowFullscreen: Enter Fullscreen
WindowFullscreen --> WindowNormal: Exit Fullscreen
note right of WindowFullscreen: Menu bar now hidden in Windows
WindowNormal: Menu bar visible
WindowFullscreen: Menu bar hidden
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CI Failure Feedback 🧐(Checks updated until commit ea5ea47)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
Superseded by #14. |
Bumps the electron-dependency-update group with 1 update in the /packages/scalar-app directory: electron.
Updates
electron
from 33.2.1 to 34.0.0Release notes
Sourced from electron's releases.
... (truncated)
Commits
c868963
docs: correct breaking changes versions (#45189)b9b6aeb
docs: update timelines for E35 (#45174)6bc6d10
perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set (#45163)1323e22
chore: bump chromium to 132.0.6834.83 (34-x-y) (#45164)bc00450
refactor: remove redundant CreateExtensionsClient() (#45155)1ecc574
test: reenable disabled GHA windows tests (#45075)0b12d0e
chore: cherry-pick 3dc17c46 from chromium (#45127)68a410d
chore: bump chromium to 132.0.6834.57 (34-x-y) (#45066)314bc3e
fix: better prompt not supported message in window-setup.ts (#45045)33065a8
docs: remove extra " (#45041)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditionsSummary by Sourcery
Build: