-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump library/alpine from 3.20.2 to 3.20.3 #4
Conversation
Signed-off-by: gitworkflows <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: gitworkflows <[email protected]>
Signed-off-by: gitworkflows <[email protected]>
Dockerfile
Outdated
FROM docker.io/library/alpine:3.20.3 | ||
RUN apk add --no-cache curl iputils bind-tools tcpdump | ||
ENTRYPOINT ["/usr/bin/curl"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Implement a multi-stage build to reduce the final image size [Enhancement, importance: 7]
FROM docker.io/library/alpine:3.20.3 | |
RUN apk add --no-cache curl iputils bind-tools tcpdump | |
ENTRYPOINT ["/usr/bin/curl"] | |
FROM docker.io/library/alpine:3.20.3@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d AS builder | |
RUN apk add --no-cache curl iputils bind-tools tcpdump | |
FROM docker.io/library/alpine:3.20.3@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d | |
COPY --from=builder /usr/bin/curl /usr/bin/curl | |
COPY --from=builder /usr/bin/ping /usr/bin/ping | |
COPY --from=builder /usr/bin/dig /usr/bin/dig | |
COPY --from=builder /usr/sbin/tcpdump /usr/sbin/tcpdump | |
ENTRYPOINT ["/usr/bin/curl"] |
Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com> Signed-off-by: gitworkflows <[email protected]>
Signed-off-by: gitworkflows <[email protected]>
Notes for Reviewers
This PR fixes #
Signed commits