Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump library/alpine from 3.20.2 to 3.20.3 #4

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

gitworkflows
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • [*] Yes, I signed my commits.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Update
The Alpine base image has been updated from version 3.18.4 to 3.20.3. Verify if this update is compatible with the project requirements and if it introduces any breaking changes.

Copy link

codiumai-pr-agent-free bot commented Oct 15, 2024

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Enhancement
✅ Implement a multi-stage build to reduce the final image size

Consider using a multi-stage build to reduce the final image size. You can create a
separate stage for installing tools and then copy only the necessary files to the
final stage.

Dockerfile [6-8]

+FROM docker.io/library/alpine:3.20.3@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d AS builder
+RUN apk add --no-cache curl iputils bind-tools tcpdump
+
 FROM docker.io/library/alpine:3.20.3@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d
-RUN apk add --no-cache curl iputils bind-tools tcpdump
+COPY --from=builder /usr/bin/curl /usr/bin/curl
+COPY --from=builder /usr/bin/ping /usr/bin/ping
+COPY --from=builder /usr/bin/dig /usr/bin/dig
+COPY --from=builder /usr/sbin/tcpdump /usr/sbin/tcpdump
 ENTRYPOINT ["/usr/bin/curl"]

[Suggestion has been applied]

Suggestion importance[1-10]: 7

Why:

7
Best practice
Pin specific versions of installed packages for reproducible builds

Consider pinning the specific versions of the installed packages to ensure
reproducible builds and avoid potential issues with future package updates.

Dockerfile [7]

-RUN apk add --no-cache curl iputils bind-tools tcpdump
+RUN apk add --no-cache curl=8.5.0-r0 iputils=20221126-r0 bind-tools=9.18.19-r0 tcpdump=4.99.4-r1
  • Apply this suggestion
Suggestion importance[1-10]: 7

Why:

7

💡 Need additional feedback ? start a PR chat

Dockerfile Outdated
Comment on lines 6 to 8
FROM docker.io/library/alpine:3.20.3
RUN apk add --no-cache curl iputils bind-tools tcpdump
ENTRYPOINT ["/usr/bin/curl"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Implement a multi-stage build to reduce the final image size [Enhancement, importance: 7]

Suggested change
FROM docker.io/library/alpine:3.20.3
RUN apk add --no-cache curl iputils bind-tools tcpdump
ENTRYPOINT ["/usr/bin/curl"]
FROM docker.io/library/alpine:3.20.3@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d AS builder
RUN apk add --no-cache curl iputils bind-tools tcpdump
FROM docker.io/library/alpine:3.20.3@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d
COPY --from=builder /usr/bin/curl /usr/bin/curl
COPY --from=builder /usr/bin/ping /usr/bin/ping
COPY --from=builder /usr/bin/dig /usr/bin/dig
COPY --from=builder /usr/sbin/tcpdump /usr/sbin/tcpdump
ENTRYPOINT ["/usr/bin/curl"]

gitworkflows and others added 2 commits October 15, 2024 15:36
Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com>
Signed-off-by: gitworkflows <[email protected]>
Signed-off-by: gitworkflows <[email protected]>
@gitworkflows gitworkflows merged commit e33978e into master Oct 15, 2024
5 checks passed
@gitworkflows gitworkflows deleted the dependabot/docker/library/alpine-3.20.3 branch October 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant