-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update builder.go #49
Conversation
Signed-off-by: NxPKG <[email protected]>
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
Reviewer's Guide by SourceryThis pull request updates the Updated class diagram for BuilderclassDiagram
class Builder {
- db db.DB
- updateInterval time.Duration
}
note for Builder "updateInterval is now expressed as 'time.Hour * 24 * 3' for better readability."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NxPKG - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify that the
updateInterval
constant is set to the expected value.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: NxPKG <[email protected]>
User description
Addresses issue: #
Changes proposed in this pull request:
PR Type
Bug fix
Description
updateInterval
constant.Changes walkthrough 📝
builder.go
Fixed `updateInterval` time calculation
pkg/builder/builder.go
updateInterval
constant to use a clearer and more accuratetime calculation.