Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rubocop to "~> 1.73.0" #579

Open
wants to merge 1 commit into
base: FEAT/fixer
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 27, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) "~> 1.71.2" -> "~> 1.73.0" age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.73.0

Compare Source

New features
Bug fixes
  • #​13867: Fix an error for plugins when not running RuboCop through Bundler. ([@​earlopain][])
  • #​13902: Fix false negative for Style/RedundantSelfAssignment when the method receives a block. ([@​vlad-pisanov][])
  • #​13826: Fix false positives for regex cops when Lint/MixedCaseRange is enabled. ([@​earlopain][])
  • #​13818: Fix false positives for Lint/Void when using operator method call without argument. ([@​koic][])
  • #​13896: Fix a false positive for Style/TrivialAccessors with instance_eval and numblocks. ([@​earlopain][])
  • #​13910: Fix false positives for Style/EndlessMethod when using setter method definitions. ([@​koic][])
  • #​13889: Fix autocorrection for Layout/LineLength with interpolated strings when not on the first line. ([@​dvandersluis][])
  • #​13900: Fix infinite loop between Layout/EmptyLinesAroundAccessModifier and Layout/EmptyLinesAroundBlockBody with EnforcedStyle: no_empty_lines. ([@​dvandersluis][])
  • #​12692: Fix Style/AccessorGrouping with constants. ([@​tejasbubane][])
  • #​13882: Fix Style/RedundantFormat for annotated template strings with missing hash keys. ([@​dvandersluis][])
  • #​13880: Fix Style/RedundantFormat when given double-splatted arguments. ([@​dvandersluis][])
  • #​13907: Don't offer autocorrect for Style/StringConcatenation when numblocks are used. ([@​earlopain][])
  • #​13876: Don't consider require 'pp' to be redundant for Lint/RedundantRequireStatement. ([@​earlopain][])
  • #​13885: Update Style/HashExcept and Style/HashSlice to not register an offense if selecting over the hash value. ([@​dvandersluis][])
Changes
  • #​12948: Add ForbiddenNames configuration to Naming/VariableName to specify names that are forbidden. ([@​dvandersluis][])
  • #​13117: Add partial autocorrect support to Lint/LiteralAsCondition cop to check for redundant conditions. ([@​zopolis4][])
  • #​13892: Allow merging of configured arrays and non-arrays. ([@​sambostock][])
  • #​13833: Add Reference to common params. ([@​sambostock][])
  • #​13890: Update Lint/RedundantTypeConversion to not register an offense when given a constructor with exception: false. ([@​dvandersluis][])
  • #​13729: Update Style/RedundantCondition cop to detect conditional expressions where the true branch is true and suggest replacing them with a logical OR. ([@​datpmt][])

v1.72.2

Compare Source

Bug fixes
  • #​13853: Fix exclusion of relative paths in plugin's AllCops: Exclude as expected. ([@​koic][])
  • #​13844: Fix an error for Style/RedundantFormat when a template argument is used without keyword arguments. ([@​koic][])
  • #​13857: Fix an error for Style/RedundantFormat when numeric placeholders is used in the template argument. ([@​koic][])
  • #​13861: Fix ArgumentError related to two deprecated AllowedPattern APIs. ([@​koic][])
  • #​13849: Fix an error for Lint/UselessConstantScoping when multiple assigning to constants after private access modifier. ([@​koic][])
  • #​13856: Fix false positives for Lint/UselessConstantScoping when a constant is used after private access modifier with arguments. ([@​koic][])
Changes

v1.72.1

Compare Source

Bug fixes
  • #​13836: Fix an error for Style/RedundantParentheses when a different expression appears before a range literal. ([@​koic][])
  • #​13839: Fix false positives for Lint/RedundantTypeConversion when passing block arguments when generating a Hash or a Set. ([@​koic][])
Changes
  • #​13839: Extension plugin is loaded automatically with `require 'rubocop/rspec/support'. ([@​koic][])

v1.72.0

Compare Source

New features
Bug fixes
  • #​13807: Fix false negatives for Style/RedundantParentheses when chaining [] method calls. ([@​koic][])
  • #​13788: Fix false negatives for Style/RedundantParentheses when [] method is called with variable or constant receivers. ([@​koic][])
  • #​13811: Fix false negatives for Style/RedundantParentheses when handling range literals with redundant parentheses. ([@​koic][])
  • #​13796: Fix crash in Layout/EmptyLinesAroundMethodBody for endless methods. ([@​dvandersluis][])
  • #​13817: Fix false positive for format specifier with non-numeric precision. ([@​dvandersluis][])
  • #​12672: Fix false positives for Lint/FormatParameterMismatch when the width value is interpolated. ([@​dvandersluis][])
  • #​12795: Fix Layout/BlockAlignment for blocks that are the body of an endless method. ([@​dvandersluis][])
  • #​13822: Fix undefined method Logger when processing watched file notifications. ([@​vinistock][])
  • #​13805: Make the language_server-protocol dependency version stricter. ([@​koic][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Jan 27, 2025

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: dependencies/Gemfile.lock
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...

Could not find compatible versions

Because standard >= 1.44.0, < 1.45.0 depends on rubocop ~> 1.70.0
  and standard >= 1.43.0, < 1.44.0 depends on rubocop ~> 1.69.1,
  standard >= 1.43.0, < 1.45.0 requires rubocop ~> 1.69.1 OR ~> 1.70.0.
And because standard >= 1.45.0 depends on rubocop ~> 1.71.0,
  standard >= 1.43.0 requires rubocop ~> 1.69.1 OR ~> 1.70.0 OR ~> 1.71.0.
So, because Gemfile depends on rubocop ~> 1.73.0
  and Gemfile depends on standard ~> 1.43,
  version solving has failed.

Copy link

sourcery-ai bot commented Jan 27, 2025

Reviewer's Guide by Sourcery

This pull request updates the rubocop dependency from version 1.70.0 to 1.71.0.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the rubocop gem dependency.
  • Updated rubocop dependency from ~> 1.70.0 to ~> 1.71.0
dependencies/Gemfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!

@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from bc05958 to 8bc9379 Compare February 14, 2025 16:14
@renovate renovate bot changed the title chore(deps): update dependency rubocop to "~> 1.71.0" chore(deps): update dependency rubocop to "~> 1.72.0" Feb 14, 2025
Copy link

qodo-merge-pro-for-open-source bot commented Feb 14, 2025

CI Feedback 🧐

(Feedback updated until commit b317576)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: Build and Test (standard)

Failed stage: Build Image [❌]

Failure summary:

The action failed due to a dependency conflict in the npm installation process:

  • [email protected] requires eslint version "^7.32.0 || ^8.2.0"
  • However, the project is using [email protected] which is incompatible
  • The build failed because it was run with --strict-peer-deps flag and couldn't resolve this conflict
  • The error suggests using --no-strict-peer-deps, --force, or --legacy-peer-deps to resolve the issue

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    634:  #22 [internal] load metadata for docker.io/koalaman/shellcheck:v0.10.0
    635:  #22 DONE 0.9s
    636:  #45 [internal] load metadata for docker.io/alpine/terragrunt:1.10.3
    637:  #45 DONE 0.9s
    638:  #46 [internal] load .dockerignore
    639:  #46 transferring context: 1.70kB done
    640:  #46 DONE 0.0s
    641:  #47 importing cache manifest from ghcr.io/khulnasoft-lab/awesome-linter:latest-buildcache
    642:  #47 ERROR: failed to configure registry cache importer: ghcr.io/khulnasoft-lab/awesome-linter:latest-buildcache: not found
    ...
    
    1402:  #89 8.989 Executing busybox-1.36.1-r29.trigger
    1403:  #89 9.049 OK: 447 MiB in 138 packages
    1404:  #89 ...
    1405:  #84 [npm-builder 4/4] RUN apk add --no-cache --virtual .node-build-deps   npm   && npm install --strict-peer-deps   && npm cache clean --force   && chown -R "$(id -u)":"$(id -g)" node_modules   && rm -rfv package.json package-lock.json
    1406:  #84 0.934 (1/2) Installing npm (10.9.1-r0)
    1407:  #84 1.674 (2/2) Installing .node-build-deps (20250303.142350)
    1408:  #84 1.681 Executing busybox-1.36.1-r29.trigger
    1409:  #84 1.694 OK: 87 MiB in 40 packages
    1410:  #84 8.608 npm error code ERESOLVE
    1411:  #84 8.608 npm error ERESOLVE could not resolve
    1412:  #84 8.608 npm error
    1413:  #84 8.609 npm error While resolving: [email protected]
    1414:  #84 8.609 npm error Found: [email protected]
    1415:  #84 8.609 npm error node_modules/eslint
    1416:  #84 8.609 npm error   eslint@"^9.20.1" from the root project
    1417:  #84 8.609 npm error   peer eslint@"^7.5.0 || ^8.0.0 || ^9.0.0" from @babel/[email protected]
    1418:  #84 8.609 npm error   node_modules/@babel/eslint-parser
    1419:  #84 8.609 npm error     @babel/eslint-parser@"^7.26.8" from the root project
    1420:  #84 8.609 npm error     @babel/eslint-parser@"^7.25.1" from @react-native/[email protected]
    1421:  #84 8.609 npm error     node_modules/@react-native/eslint-config
    1422:  #84 8.609 npm error       @react-native/eslint-config@"^0.77.1" from the root project
    1423:  #84 8.609 npm error     1 more (eslint-plugin-ft-flow)
    1424:  #84 8.609 npm error   24 more (@eslint-community/eslint-utils, ...)
    1425:  #84 8.609 npm error
    1426:  #84 8.609 npm error Could not resolve dependency:
    1427:  #84 8.609 npm error peer eslint@"^7.32.0 || ^8.2.0" from [email protected]
    1428:  #84 8.609 npm error node_modules/eslint-config-airbnb
    1429:  #84 8.609 npm error   eslint-config-airbnb@"^19.0.4" from the root project
    1430:  #84 8.609 npm error
    1431:  #84 8.609 npm error Conflicting peer dependency: [email protected]
    1432:  #84 8.609 npm error node_modules/eslint
    1433:  #84 8.609 npm error   peer eslint@"^7.32.0 || ^8.2.0" from [email protected]
    1434:  #84 8.609 npm error   node_modules/eslint-config-airbnb
    1435:  #84 8.609 npm error     eslint-config-airbnb@"^19.0.4" from the root project
    1436:  #84 8.609 npm error
    1437:  #84 8.609 npm error Fix the upstream dependency conflict, or retry
    1438:  #84 8.609 npm error this command with --no-strict-peer-deps, --force, or --legacy-peer-deps
    1439:  #84 8.609 npm error to accept an incorrect (and potentially broken) dependency resolution.
    1440:  #84 8.609 npm error
    1441:  #84 8.609 npm error
    1442:  #84 8.609 npm error For a full report see:
    1443:  #84 8.609 npm error /root/.npm/_logs/2025-03-03T14_23_51_588Z-eresolve-report.txt
    1444:  #84 8.611 npm error A complete log of this run can be found in: /root/.npm/_logs/2025-03-03T14_23_51_588Z-debug-0.log
    1445:  #84 ...
    1446:  #88 [base_image  3/60] RUN apk add --no-cache   ca-certificates   coreutils   curl   file   git   git-lfs   jq   libxml2-utils   npm   nodejs-current   openjdk17-jre   openssh-client   parallel   perl   php83   php83-ctype   php83-curl   php83-dom   php83-iconv   php83-pecl-igbinary   php83-intl   php83-mbstring   php83-openssl   php83-phar   php83-simplexml   php83-tokenizer   php83-xmlwriter   R   rakudo   ruby   zef
    1447:  #88 9.118 (66/125) Installing perl-error (0.17029-r2)
    ...
    
    1499:  #88 11.70 *
    1500:  #88 11.70 * To avoid warnings about R.css when installing R extensions also install R-doc.
    1501:  #88 11.70 *
    1502:  #88 11.70 (114/125) Installing moarvm (2024.04-r0)
    1503:  #88 11.99 (115/125) Installing nqp (2024.04-r0)
    1504:  #88 12.49 (116/125) Installing rakudo (2024.04-r0)
    1505:  #88 ...
    1506:  #84 [npm-builder 4/4] RUN apk add --no-cache --virtual .node-build-deps   npm   && npm install --strict-peer-deps   && npm cache clean --force   && chown -R "$(id -u)":"$(id -g)" node_modules   && rm -rfv package.json package-lock.json
    1507:  #84 ERROR: process "/bin/sh -c apk add --no-cache --virtual .node-build-deps   npm   && npm install --strict-peer-deps   && npm cache clean --force   && chown -R \"$(id -u)\":\"$(id -g)\" node_modules   && rm -rfv package.json package-lock.json" did not complete successfully: exit code: 1
    ...
    
    1692:  #152 CACHED
    1693:  #153 [standard  2/14] COPY --from=dotnet-sdk /usr/share/dotnet /usr/share/dotnet
    1694:  #153 CANCELED
    1695:  ------
    1696:  > importing cache manifest from ghcr.io/khulnasoft-lab/awesome-linter:latest-buildcache:
    1697:  ------
    1698:  ------
    1699:  > [npm-builder 4/4] RUN apk add --no-cache --virtual .node-build-deps   npm   && npm install --strict-peer-deps   && npm cache clean --force   && chown -R "$(id -u)":"$(id -g)" node_modules   && rm -rfv package.json package-lock.json:
    1700:  8.609 npm error     eslint-config-airbnb@"^19.0.4" from the root project
    1701:  8.609 npm error
    1702:  8.609 npm error Fix the upstream dependency conflict, or retry
    1703:  8.609 npm error this command with --no-strict-peer-deps, --force, or --legacy-peer-deps
    1704:  8.609 npm error to accept an incorrect (and potentially broken) dependency resolution.
    1705:  8.609 npm error
    1706:  8.609 npm error
    1707:  8.609 npm error For a full report see:
    1708:  8.609 npm error /root/.npm/_logs/2025-03-03T14_23_51_588Z-eresolve-report.txt
    1709:  8.611 npm error A complete log of this run can be found in: /root/.npm/_logs/2025-03-03T14_23_51_588Z-debug-0.log
    ...
    
    1714:  86 | >>> RUN apk add --no-cache --virtual .node-build-deps \
    1715:  87 | >>>   npm \
    1716:  88 | >>>   && npm install --strict-peer-deps \
    1717:  89 | >>>   && npm cache clean --force \
    1718:  90 | >>>   && chown -R "$(id -u)":"$(id -g)" node_modules \
    1719:  91 | >>>   && rm -rfv package.json package-lock.json
    1720:  92 |     
    1721:  --------------------
    1722:  ERROR: failed to solve: process "/bin/sh -c apk add --no-cache --virtual .node-build-deps   npm   && npm install --strict-peer-deps   && npm cache clean --force   && chown -R \"$(id -u)\":\"$(id -g)\" node_modules   && rm -rfv package.json package-lock.json" did not complete successfully: exit code: 1
    1723:  ##[group]Reference
    1724:  builder-4bb7e888-8568-4596-a584-98aa18eb30d2/builder-4bb7e888-8568-4596-a584-98aa18eb30d20/vtsz9hfi2bts10p8i99b60i6c
    1725:  ##[endgroup]
    1726:  ##[group]Check build summary support
    1727:  Build summary supported!
    1728:  ##[endgroup]
    1729:  ##[error]buildx failed with: ERROR: failed to solve: process "/bin/sh -c apk add --no-cache --virtual .node-build-deps   npm   && npm install --strict-peer-deps   && npm cache clean --force   && chown -R \"$(id -u)\":\"$(id -g)\" node_modules   && rm -rfv package.json package-lock.json" did not complete successfully: exit code: 1
    ...
    
    1745:  5f398fcfd265: Pull complete
    1746:  152e015ae384: Pull complete
    1747:  Digest: sha256:8a8d92fc2d7cc8a8855400970bb971436fc117bd39366595f55f7e1283a1e961
    1748:  Status: Downloaded newer image for dockereng/export-build:latest
    1749:  Process "docker run" exited with code 0
    1750:  Parsing /home/runner/work/_temp/docker-actions-toolkit-TXDBsE/export/summary.json
    1751:  Build record written to /home/runner/work/_temp/docker-actions-toolkit-TXDBsE/export/khulnasoft-lab~awesome-linter~VTSZ9H.dockerbuild (181.4 KB)
    1752:  Uploading khulnasoft-lab~awesome-linter~VTSZ9H.dockerbuild to blob storage
    1753:  ERROR: read unix @->/run/docker.sock: use of closed network connection
    ...
    
    1782:  [command]/usr/bin/git version
    1783:  git version 2.48.1
    1784:  Temporarily overriding HOME='/home/runner/work/_temp/891e6626-5969-4374-8322-12f0baffeed9' before making global git config changes
    1785:  Adding repository directory to the temporary git global config as a safe directory
    1786:  [command]/usr/bin/git config --global --add safe.directory /home/runner/work/awesome-linter/awesome-linter
    1787:  [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
    1788:  [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
    1789:  fatal: No url found for submodule path 'chktex' in .gitmodules
    1790:  ##[warning]The process '/usr/bin/git' failed with exit code 128
    

    @renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 8bc9379 to 1126586 Compare February 17, 2025 14:48
    @renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 1126586 to 805fa99 Compare February 26, 2025 11:07
    @renovate renovate bot changed the title chore(deps): update dependency rubocop to "~> 1.72.0" chore(deps): update dependency rubocop to "~> 1.73.0" Feb 26, 2025
    @renovate renovate bot force-pushed the renovate/rubocop-1.x branch from 805fa99 to b317576 Compare March 3, 2025 14:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    0 participants