Safer placeholders #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements from khibino#70 - Wrap everything created from a `Record` with `WithPlaceholderOffsets`. - Which can be easily concatenated by `Applicative` combinators such as `<*>`. - Better solution than khibino#70 (comment) and khibino#70 (comment) - (BREAKING CHANGE) Pass placeholders Record directly to `query'` etc. - Delete old (and unavailable anymore) placholders-related APIs: `placeholder` and `relation'` etc. Left Tasks ==== - Some tests doesn't pass. Fix them. - Avoid to use `toFlat` and `toAggregated` as much as possible: `ResultContext` should be adapted. - Add tests for placeholders. - You may want to refactor the design.
igrep
force-pushed
the
accumulate-ph-offsets
branch
from
5955279 to
3c7b578
Compare
igrep
force-pushed
the
accumulate-ph-offsets
branch
16 times, most recently
from
2850800 to
848fcdc
Compare
added 5 commits
May 22, 2019 10:20
No reason to hide just a type synonym of `DList Int`
igrep
force-pushed
the
accumulate-ph-offsets
branch
from
848fcdc to
1e2a7a9
Compare
igrep
commented
Jun 5, 2019
| show = showStringSQL . detachPlaceholderOffsets . (`sqlFromRelation` defaultPlaceholders) | ||
|
|
||
| defaultPlaceholders :: PersistableWidth t => Record PureOperand t | ||
| defaultPlaceholders = pwPlaceholders persistableWidth |
There was a problem hiding this comment.
I found this API should be "unsafe".
Because this enables us to refer placeholder Records even when building a Relation () a, which doesn't actually receive any placeholder parameters.
igrep
commented
Jun 17, 2019
| updateContext = QueryJoin . modify | ||
| updateContext :: Monad m => PlaceholderOffsets -> (JoinContext -> JoinContext) -> QueryJoin m () | ||
| updateContext phs f = | ||
| QueryJoin $ modify (mapWithPlaceholderOffsets (f *** (phs <>))) |
There was a problem hiding this comment.
I found a bug related to this file: there are cases where the predicate of ON clause are not printed though its attached PlaceholderOffsets is appended.
How can I fix?
|
Tests added: igrep#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements from #70
RecordwithWithPlaceholderOffsets.Applicativecombinators such as<*>.query'etc.placeholderandrelation'etc.Left Tasks
Some tests doesn't pass. Fix them.toFlatandtoAggregatedas much as possible:ResultContextshould be adapted.