Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 프리셋 케이스 최적화 #103

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

gwansikk
Copy link
Member

@gwansikk gwansikk commented Dec 12, 2024

Summary

프리셋의 삭제 엘리먼트는 함수를 통해 엘리먼트 데이터베이스에서 가져옵니다. 이젠 엘리먼트 데이터는 한 곳에서 관리할 수 있어요.
(6500줄의 프리셋 객체가 단 209줄로 단축되었어요)

@gwansikk gwansikk requested a review from SunwooJaeho December 12, 2024 11:23
@gwansikk gwansikk self-assigned this Dec 12, 2024
@gwansikk gwansikk marked this pull request as ready for review December 12, 2024 11:26
@SunwooJaeho SunwooJaeho merged commit 5c6977d into main Dec 12, 2024
2 checks passed
@SunwooJaeho SunwooJaeho deleted the refactor/preset branch December 12, 2024 11:37
Copy link
Contributor

@SunwooJaeho SunwooJaeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants