-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): update Combobox to add new workspace to state #796
base: develop
Are you sure you want to change the base?
feat(platform): update Combobox to add new workspace to state #796
Conversation
…nge dialog background color
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@@ -157,7 +158,7 @@ export function Combobox(): React.JSX.Element { | |||
<AddSVG /> New workspace | |||
</Button> | |||
</DialogTrigger> | |||
<DialogContent> | |||
<DialogContent className="bg-[#1E1E1F]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the transparency?
User description
Description
This PR adds newly created workspace to existing list of workspaces and modified background color of create workspace dialog to be consistent with other create dialog components.
Fixes #666
Dependencies
N/A
Future Improvements
N/A
Mentions
@rajdip-b
Screenshots of relevant screens
https://www.loom.com/share/d37bab94864e4d229c55026df679304a
Developer's checklist
If changes are made in the code:
PR Type
Bug fix, Enhancement
Description
Fixes issue where newly created workspace doesn't appear in the dropdown.
Updates the workspace state to include the newly created workspace.
Changes the background color of the create workspace dialog for consistency.
Changes walkthrough 📝
combobox.tsx
Fix workspace dropdown and enhance dialog UI
apps/platform/src/components/ui/combobox.tsx