Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links to Keyman engine content #522

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix: links to Keyman engine content #522

merged 3 commits into from
Dec 17, 2024

Conversation

Meng-Heng
Copy link
Collaborator

@Meng-Heng Meng-Heng commented Dec 13, 2024

Part of: #415.

There is no documentation from the $stable_version so I am adding a / to ensure the dropdown of other available versions.

Before:
image

After:
image

This PR is ready for review.

@Meng-Heng Meng-Heng added the fix label Dec 13, 2024
@Meng-Heng Meng-Heng added this to the A18S17 milestone Dec 13, 2024
@Meng-Heng Meng-Heng changed the title 404 not found links fix: 404 Not Found link in docs Dec 13, 2024
@darcywong00
Copy link
Contributor

$stable_version is defined in PHP here

public const stable_version = '17.0';

I think the issue is since 17.0 is the stable version, the links are expecting https://help.keyman.com/developer/engine/iphone-and-ipad/17.0/ content.

Adding the slash will still be a broken link because iphone-and-ipad/16.0 is the "latest" folder that exists. I think we need to seed 17.0 and 18.0 folders in the help.keyman repo

@mcdurdin
Copy link
Member

I think we need to seed 17.0 and 18.0 folders in the help.keyman repo

using current-version avoids this problem, and is the canonical link.

@darcywong00 darcywong00 changed the title fix: 404 Not Found link in docs fix: links to Keyman engine content Dec 16, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Meng-Heng Meng-Heng merged commit 187de07 into master Dec 17, 2024
2 checks passed
@Meng-Heng Meng-Heng deleted the 404-not-found-links branch December 17, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants