Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mid-sprint merge of master to staging for A18S16 #514

Merged
merged 17 commits into from
Dec 4, 2024

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Nov 29, 2024

Bringing staging branch up to date to continue development of localizing keyboard search

darcywong00 and others added 17 commits September 25, 2024 11:08
…d-details

feat: show keyboard preview in keyboard details
fix: Modify stable url for keyboard download to kmp file
Also promotes h2 to h1 where needed.

Fixes: #507
…-in-titles

feat: include 'Keyboard' in title for featured keyboards
chore: add new issues to Keyman project automatically
fix: Check languageName exists before printing in keyboard details
fix: use property_exists instead of array_key_exists
@darcywong00 darcywong00 added this to the A18S16 milestone Nov 29, 2024
@darcywong00 darcywong00 requested a review from mcdurdin December 4, 2024 02:41
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@darcywong00 darcywong00 merged commit 79813a8 into staging Dec 4, 2024
3 checks passed
@darcywong00 darcywong00 deleted the chore/merge-master-staging-a18s16 branch December 4, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants