feat: show keyboard preview in keyboard details #501
Conversation
From Chiang Mai Hackathon.
| <div class="download-description">Use $description in your web browser. No need to install anything.</div> | ||
| </div> | ||
| <a class="download-link" $embed_target href='$url'>Full online editor</a> | ||
| </div> |
There was a problem hiding this comment.
Can you note the rationale why the blue button changed
from "Use keyboard online"
to "Full online editor"? (and removed the subtext)
I don't have a strong preference. (though does "Full online editor" imply a lot more features than what KeymanWeb offers?)
There was a problem hiding this comment.
Rationale -- I agree that 'full online editor' implies a future version of keymanweb.com which has awesomesauce which we just don't currently have. I wanted to differentiate between the one line test box and the more fully featured keymanweb.com, and am open to other ideas.
I thought "Use keyboard online" was confusing because with this new feature the user will already be using the keyboard online. I removed the subtext because it seemed self-evident as it was below the existing keyboard. (I could add the subtext back again for pages which don't have the preview)
_includes/2020/KeymanWebHost.php
Outdated
| $build = $json->version; | ||
| } else { | ||
| // If the get-version API fails, we'll use the latest known stable version | ||
| $build = "16.0.145"; |
There was a problem hiding this comment.
Should this be 17.0.332?
There was a problem hiding this comment.
I think there was still lingering 17.0 style issues
🔗 keymanapp/help.keyman.com#1518
There was a problem hiding this comment.
Resolved in keymanapp/help.keyman.com#1530 (was a help.keyman.com issue)
| // Create a new on screen keyboard view and tell KeymanWeb that | ||
| // we are using the targetDevice for context input. | ||
| const targetDevice = { | ||
| browser: 'chrome', formFactor: 'desktop', OS: '<?=$webDevice?>', |
There was a problem hiding this comment.
Does it work on Firefox if we set it to chrome here?
| (function() { | ||
| keyman.init({attachType:'auto'}); | ||
| keyman.addKeyboards('@en'); // Loads default English keyboard from Keyman Cloud (CDN) | ||
| keyman.addKeyboards('@th'); // Loads default Thai keyboard from Keyman Cloud (CDN) |
There was a problem hiding this comment.
Why do we load EN and TH keyboards by default?
There was a problem hiding this comment.
This is an example only ... and long ago that was a good sample of keyboards. We could change it to another example one day.
From Chiang Mai Hackathon.
Notes:
z-index: 10000leaking into hosted osk from KMW. (TODO)