Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document longpress-shortcut gesture in Android help #1789

Closed
wants to merge 1 commit into from

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Jan 15, 2025

Adds documentation to help answer any future inquiries along the line of https://community.software.sil.org/t/do-longpress-keys-include-a-flick-gesture-automatically/9658/1.

I don't see any corresponding gesture docs for iOS or for the Keyman Engine for Web help section, so no such changes or additions are made here for those two platforms.

@@ -8,6 +8,8 @@ There are now several gestures available to interact with some keys on the keybo
![](../android_images/touch-hold-ap.png)

* **Long press**: Press and hold a key, and after a moment a submenu will appear. Slide the finger to the submenu to select a key. Release the finger, and the highlighted key from the submenu will be output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line helps ensure consistent formatting for the list items; without it, the second bullet point had extra indentation compared to the other two.

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Can you make the change in the main repo?
https://github.com/keymanapp/keyman/blob/master/android/docs/help/context/gestures.md

Also FYI while you were away, the Keyman engine help documentation is also in the main repo now under each platform's docs/engine/

@darcywong00 darcywong00 added this to the A18S19 milestone Jan 15, 2025
@jahorton
Copy link
Contributor Author

Thanks for the update. Can you make the change in the main repo? https://github.com/keymanapp/keyman/blob/master/android/docs/help/context/gestures.md

Does it need to be updated in both places, or just there? We should probably make a similar section for iOS, and it'll have impact for that work item too.

@mcdurdin
Copy link
Member

Does it need to be updated in both places, or just there?

Just in the main repo. It gets deployed automatically to the help repo.

@jahorton
Copy link
Contributor Author

Redone as keymanapp/keyman#12899.

@jahorton
Copy link
Contributor Author

For iOS: keymanapp/keyman#12900

@darcywong00
Copy link
Contributor

The sync from the main repo is live on the help site

https://help.keyman.com/products/android/18.0/context/gestures

@jahorton
Copy link
Contributor Author

Closing in favor of the auto-sync'd content from the main repo.

@jahorton jahorton closed this Jan 16, 2025
@jahorton jahorton deleted the feat/longpress-shortcut-doc branch January 16, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants