feat(backend): e2e tests for creating a pull request (#61) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message changed but the tests didn't...
Without these two lines the tests hang and eventually fail.
mcdurdin
reviewed
May 5, 2020
| ) { | ||
| throw new Error('Non-linear history. Force-push is not allowed.'); | ||
| if (keyboardsHead !== keyboardsNoteInfo.commitSha && keyboardsNoteInfo.commitSha !== '') { | ||
| throw new HttpException('Keyboards repo has new changes. This is not allowed.', 409); |
There was a problem hiding this comment.
Can you explain the circumstances of this? The keyboards repo will continually get new changes so we need to handle that
There was a problem hiding this comment.
What I meant here is that the single-keyboard directory (that corresponds to the single-keyboard repo) has new changes.
| if (keyboardsHead !== keyboardsNoteInfo.commitSha && keyboardsNoteInfo.commitSha !== '') { | ||
| throw new Error('Keyboards repo has new changes. This is not allowed.'); | ||
| if (this.hasNonLinearHistory(singleKbNoteInfo, keyboardsNoteInfo)) { | ||
| throw new HttpException('Non-linear history in single-keyboard repo. Force-push is not allowed.', 400); |
There was a problem hiding this comment.
Is this just for a single PR? We don't allow force push for PRs generated through KDO?
There was a problem hiding this comment.
yes, that's for a single PR and is relevant while a PR is open.
I wrote up #63 with some additional scenarios that the current implementation might not properly handle yet.
mcdurdin
approved these changes
May 6, 2020
|
I note a failing test in the log... |
This change makes calling git cross-platform compatible. Suppressing stderr output can be done directly in node. This allows to run the command on all platforms.
Now that I found the real reason for the "command not found" error (there's no /dev/null on Windows), we can remove the workaround for TC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is