Upgrade Rails to v7.2 #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
3 times, most recently
from
8ddaf6f to
1b77d56
Compare
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
1b77d56 to
698d957
Compare
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
2 times, most recently
from
d3dc80e to
666f8c6
Compare
ezekg
commented
Nov 12, 2024
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
2 times, most recently
from
bdb9b19 to
e042944
Compare
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
2 times, most recently
from
c094b22 to
25329b4
Compare
ezekg
commented
Nov 12, 2024
| unless license.send(:secure_compare, digest, license.key) | ||
| Keygen.logger.warn { "[license-key-lookup-service] rehashing key: license_id=#{license.id.inspect}" } | ||
|
|
||
| license.update!(key: digest) |
There was a problem hiding this comment.
Eventually, once all in-use licenses and tokens have been rehashed, we need to upgrade bcrypt. If there happen to be any that we missed after 30 days, they will begin failing hash comparison, but we can either manually rehash these tokens once reported on a case-by-case basis, or instruct the user to regenerate the token.
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
25329b4 to
86bd9d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.