Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default and optional client scopes per realm via dedicated resources #1079

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

pboehm
Copy link
Contributor

@pboehm pboehm commented Jan 20, 2025

Allow configuring the set of "default client scopes" and "optional client scopes" for a realm using two new dedicated resources keycloak_realm_default_client_scopes and keycloak_realm_optional_client_scopes.

There are currently multiple open issues with the existing solution via attributes on the keycloak_realm resource #470 #547 #701 which should all be addressed by this PR.

@thomasdarimont
Copy link
Contributor

@pboehm Thanks for your PR! I think the PR is missing the DCO aka "sign-off" on the commits.

…alm via dedicated resources

Signed-off-by: Philipp Böhm <[email protected]>
@pboehm pboehm force-pushed the realm_default_and_optional_client_scopes branch from ef65abe to 425c754 Compare January 20, 2025 13:32
@pboehm
Copy link
Contributor Author

pboehm commented Jan 20, 2025

@pboehm Thanks for your PR! I think the PR is missing the DCO aka "sign-off" on the commits.

@thomasdarimont I've squashed my commits and added a sign-off

Copy link
Contributor

@thomasdarimont thomasdarimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sschu sschu merged commit 93db672 into keycloak:main Jan 23, 2025
9 checks passed
@pboehm pboehm deleted the realm_default_and_optional_client_scopes branch January 23, 2025 16:45
angeloxx pushed a commit to angeloxx/terraform-provider-keycloak that referenced this pull request Jan 26, 2025
…alm via dedicated resources (keycloak#1079)

Signed-off-by: Philipp Böhm <[email protected]>
Signed-off-by: angeloxx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants