Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

MSVS 2015 support #46

Open
wants to merge 6 commits into
base: electron_v1.6.2
Choose a base branch
from

Conversation

paulprins
Copy link

Ported some changes from the tjanczuk/edge to move to msvs 2015 (from 13). I also switched up the prebuilt library numbers to use the electron version numbers. Also this is working with 1.6.11 for both 32 & 64 bit).

Note: Going forward that the prebuilt version numbers are for Electron, not node.

@kexplo
Copy link
Owner

kexplo commented Jul 1, 2017

392a032
why did this?
I want the electron-edge will be compatible even if the electron is updated. (Until the node version of the electron goes up)
another commit is good. thanks

@paulprins
Copy link
Author

paulprins commented Jul 1, 2017

I did this because electron-builder was rebuilding electron-edge with the node based versions. Yet when I built out the *.node libraries I used the following script:

node-gyp rebuild --target=1.6.11 --arch=ia32 --dist-url=https://atom.io/download/atom-shell --module_path=lib/ --python=python2.7 --msvs_version=2015
node-gyp rebuild --target=1.6.11 --arch=x64 --dist-url=https://atom.io/download/atom-shell --module_path=lib/ --python=python2.7 --msvs_version=2015

Changing the folder numbers to match the target took care of the rebuilding. I could be misunderstanding how that process works (I did not dig in to deeply with it).

It was also built with node v6.5.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants