Move futures-lite to dev-dependencies #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency is only used by `examples/`. Moving it to `dev-dependencies` prevents it from being propagated to users of the library.
|
Thanks! |
tuna-f1sh
pushed a commit
to tuna-f1sh/nusb
that referenced
this pull request
Sep 26, 2024
fixup: use proper `nl_groups` for `Monitor::snl`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this an interesting library!
I noticed
futures-liteis only used inexamples/and (non-running) documentation tests. This change moves that dependency todev-dependenciesfromdependenciessince it's not used by the library itself. This means it's not added to the dependency tree of thenusb's users.