Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for reading routing operational data for IPv4 #217

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Add support for reading routing operational data for IPv4 #217

merged 2 commits into from
Nov 23, 2023

Conversation

mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Nov 22, 2023 •
edited by rical
Loading

In the CLI:
admin@infix-00-00-00:/> show routes

PREFIX                        DESTINATION                   PROTOCOL  METRIC
1.1.1.0/24                    e0                            kernel
192.168.100.0/24              1.1.1.1                       static    20
192.168.110.2/32              blackhole                     static    20
192.168.120.2/32              blackhole                     static    20
192.168.130.2/32              unreachable                   static    20

EDIT by @rical : framed output in markdown ```

rical
rical reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@rical rical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks great. I left some minor commends, mostly cosmetic. I good idea might be to run your diff though checkpatch.pl from the kernel.

Again, looks really good overall.

board/netconf/rootfs/lib/infix/cli-pretty Outdated Show resolved Hide resolved
src/statd/statd.c Outdated Show resolved Hide resolved
src/statd/statd.c Outdated Show resolved Hide resolved
src/statd/statd.c Outdated Show resolved Hide resolved
src/statd/statd.c Outdated Show resolved Hide resolved
src/statd/statd.c Show resolved Hide resolved
src/statd/statd.c Outdated Show resolved Hide resolved
troglobit
troglobit requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rical's findings.

Additionally, I think I'd like to see the metric column earlier, before protocol/origin.

@mattiaswal
Add support for reading routing operational data for IPv4
6055009 
In the CLI:
admin@infix-00-00-00:/> show routes
PREFIX                        DESTINATION                   PROTOCOL  METRIC
1.1.1.0/24                    e0                            kernel
192.168.100.0/24              1.1.1.1                       static    20
192.168.110.2/32              blackhole                     static    20
192.168.120.2/32              blackhole                     static    20
192.168.130.2/32              unreachable                   static    20
@mattiaswal mattiaswal force-pushed the add-routing-operational branch from e010697 to 6055009 Compare November 22, 2023 08:51
troglobit
troglobit approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Looking forward to an update in doc/networking.md, example of how to add a route and read routing table remotely using NETCONF ;-)

@mattiaswal
Rename infix-routing to correct date
45650b5 
Should be 2023 not 2013.
@mattiaswal mattiaswal force-pushed the add-routing-operational branch from 16736df to 45650b5 Compare November 23, 2023 08:38
@mattiaswal mattiaswal merged commit a0a80c8 into main Nov 23, 2023
2 checks passed
@mattiaswal mattiaswal deleted the add-routing-operational branch November 23, 2023 09:30
@troglobit troglobit added this to the Infix v23.11 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rical rical rical left review comments

@troglobit troglobit troglobit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Infix v23.11
Development

Successfully merging this pull request may close these issues.
3 participants
@mattiaswal @troglobit @rical