Regen factory on every boot #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operational experience shows that the current Infix Fail Secure mode, introduced in ca9daef, does not work in practice. The factory datastore in sysrepo is created at boot with the YANG models and the factory-config file. When the factory-config file is generated from older versions of these models, the resulting datastore may fail to pass the validation and system will end up in an unrecoverable state. Instead, both the factory-config and failure-config must be created at every boot to match the YANG models in the active Linux image. This ensures loading the YANG models will always work and the system can proceed to attempt to load startup-config to the running datastore. If loading startup-config fails we can fall back to failure-config, which like factory-config, will then provide a way to log in an dianose the system. Signed-off-by: Joachim Wiberg <[email protected]>
wkz
reviewed
Oct 30, 2023
A list of interfaces: x10 x9 x8 x7 x6 x5 x4 x1 x2 x3 should be sorted in order with x10 last. Using the common 'sort -n' would generate: x1 x10 x2 ... so we use version sort. This way we can ensure that the order of bridge ports is natural and what end users expect. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
force-pushed
the
regen-factory-on-every-boot
branch
from
abf5fe3 to
07a8b6b
Compare
wkz
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the annoying "RMA" issue we've seen over the past week or so. Instead of saving
factory-configandfailure-configto/cfg, we now regenerate them on each boot to match our YANG models. The files are stored in/run/confd/, except forstartup-configthat remains in/cfg.It also address the "unsorted interfaces" issue we found in customer bridge created by
gen-interfacestoday.