Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infix-vlan: Create a custom vlan model #179

Merged
merged 1 commit into from
Oct 27, 2023
Merged

infix-vlan: Create a custom vlan model #179

merged 1 commit into from
Oct 27, 2023

Conversation

mattiaswal
Copy link
Contributor

This implements the new model infix-if-vlan.
The new CLI is:

root@infix-00-00-00:/config/interfaces/interface/vlan10/> set vlan id 10 lower-layer-if eth0

with an possible extra option for tag-type, default tag-type is c-vlan.

@mattiaswal mattiaswal requested a review from troglobit October 26, 2023 13:57
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found very little to comment on in this PR so I'll be nitpicking about coding style and yang style mostly. Otherwise really good job!

test/case/ietf_interfaces/vlan_ping.py Show resolved Hide resolved
src/confd/src/ietf-interfaces.c Outdated Show resolved Hide resolved
src/confd/src/ietf-interfaces.c Outdated Show resolved Hide resolved
src/confd/src/ietf-interfaces.c Outdated Show resolved Hide resolved
src/confd/src/ietf-interfaces.c Outdated Show resolved Hide resolved
src/confd/yang/[email protected] Outdated Show resolved Hide resolved
src/confd/yang/[email protected] Outdated Show resolved Hide resolved
src/statd/iface-ip-link.c Outdated Show resolved Hide resolved
src/statd/iface-ip-link.c Outdated Show resolved Hide resolved
src/statd/iface-ip-link.c Outdated Show resolved Hide resolved
@mattiaswal mattiaswal force-pushed the infix-vlan branch 7 times, most recently from bf506c0 to 47020a5 Compare October 27, 2023 06:45
This implements the new model infix-if-vlan.
The new CLI is:

root@infix-00-00-00:/config/interfaces/interface/vlan10/> set vlan id 10 lower-layer-if eth0

with an possible extra option for tag-type, default tag-type is c-vlan.
@troglobit
Copy link
Contributor

Tests pass (on the PR action, the other one was skipped due to duplicate), merging! 🙌

@troglobit troglobit merged commit 941fc31 into main Oct 27, 2023
@troglobit troglobit deleted the infix-vlan branch October 27, 2023 08:53
@troglobit troglobit added this to the Infix v23.10 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants