cache: Support downloading without Content-Length #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for caching URLs which don't include the Content-Length headers in their response. For now keep downloading fully into memory first, but download even without Content-Length until the limit is hit. Abort the caching if it is. Update the test to verify the contents of the cached URLs, as now we're messing with it ourselves. Switch to using raw GitHub URLs as samples, as those don't change unless we change them ourselves. This fixes the test which started failing because GitHub stopped supplying Content-Length on the URLs. This should now enable downloading artifacts from KernelCI and possibly others. Although we'll still be downloading only 1/256th of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for caching URLs which don't include the Content-Length headers in their response. For now keep downloading fully into memory first, but download even without Content-Length until the limit is hit. Abort the caching if it is.
Update the test to verify the contents of the cached URLs, as now we're messing with it ourselves. Switch to using raw GitHub URLs as samples, as those don't change unless we change them ourselves.
This fixes the test which started failing because GitHub stopped supplying Content-Length on the URLs. This should now enable downloading artifacts from KernelCI and possibly others. Although we'll still be downloading only 1/256th of them.