Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pad_to_aspect_ratio flag to ImageConverter #2045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add pad_to_aspect_ratio flag to ImageConverter #2045

wants to merge 1 commit into from
+40 −14

Conversation

sineeli
Copy link
Collaborator

@sineeli sineeli commented Jan 16, 2025 •
edited
Loading

Add pad_to_aspect_ratio flag which can be useful in some of Vision pipelines.

@sineeli sineeli requested a review from mattdangerw January 16, 2025 23:06
mattdangerw
mattdangerw approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But two issue before merge..

  • formatting needs updating, pip install -U ruff and reformat
  • the new test is failing on torch, we should look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sineeli @mattdangerw