Added tests for mithril #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
Sep 17, 2018
| const {getByText} = getQueriesForElement(div) | ||
| const counter = getByText('0') | ||
| fireEvent.click(counter) | ||
| await wait(() => expect(counter).toHaveTextContent('1')) |
There was a problem hiding this comment.
Instead of using wait here, could you use fireEventAsync (see hyperapp.test.js for an example).
There was a problem hiding this comment.
That's what I tried to begin with, but the test suite still fails. Here's the code:
test('renders a counter', async () => {
const div = document.createElement('div')
m.mount(div, Counter)
const {getByText} = getQueriesForElement(div)
const counter = getByText('0')
await fireEventAsync.click(counter)
expect(counter).toHaveTextContent('1')
await fireEventAsync.click(counter)
expect(counter).toHaveTextContent('2')
})There was a problem hiding this comment.
Weird. Maybe it takes longer than a single tick of the event loop to rerender for some reason. Ok, thanks!
kentcdodds
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used a
waitin the tests because mithril renders on nextTick. I'm unsure if this is the right way to test it though.