Adds options for lowUpperBound and highLowerBound for HTML reports

kennaar · Oct 2, 2020 · bb52378 · bb52378
1 parent 632e061
commit bb52378
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -37,6 +37,8 @@ $ vendor/bin/phpunit-merger coverage <directory> [--html=<directory>] [<file>]
 **Options**
 
 - `html`: Directory where the HTML report should be stored 
+- `lowUpperBound`: (optional) The lowUpperBound value to be used for HTML format 
+- `highLowerBound`: (optional) The highLowerBound value to be used for HTML format 
 
 ### Log
 

diff --git a/src/PhpunitMerger/Command/CoverageCommand.php b/src/PhpunitMerger/Command/CoverageCommand.php
@@ -37,6 +37,18 @@ protected function configure()
                 null,
                 InputOption::VALUE_REQUIRED,
                 'The directory where to write the code coverage report in HTML format'
+            )
+            ->addOption(
+                'lowUpperBound',
+                null,
+                InputOption::VALUE_REQUIRED,
+                'The lowUpperBound value to be used for HTML format'
+            )
+            ->addOption(
+                'highLowerBound',
+                null,
+                InputOption::VALUE_REQUIRED,
+                'The highLowerBound value to be used for HTML format'
             );
     }
 
@@ -59,7 +71,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $this->writeCodeCoverage($codeCoverage, $output, $input->getArgument('file'));
         $html = $input->getOption('html');
         if ($html !== null) {
-            $this->writeHtmlReport($codeCoverage, $html);
+            $lowUpperBound = $input->getOption('lowUpperBound') ?: 50;
+            $highLowerBound = $input->getOption('highLowerBound') ?: 90;
+            $this->writeHtmlReport($codeCoverage, $html, $lowUpperBound, $highLowerBound);
         }
 
         return 0;
@@ -86,9 +100,9 @@ private function writeCodeCoverage(CodeCoverage $codeCoverage, OutputInterface $
         }
     }
 
-    private function writeHtmlReport(CodeCoverage $codeCoverage, string $destination)
+    private function writeHtmlReport(CodeCoverage $codeCoverage, string $destination, int $lowUpperBound, int $highLowerBound)
     {
-        $writer = new Facade();
+        $writer = new Facade($lowUpperBound, $highLowerBound);
         $writer->process($codeCoverage, $destination);
     }
 }
diff --git a/tests/PhpunitMerger/Command/Coverage/CoverageCommandTest.php b/tests/PhpunitMerger/Command/Coverage/CoverageCommandTest.php
@@ -75,6 +75,29 @@ public function testCoverageWritesHtmlReport()
         $this->assertFileExists($this->logDirectory . $this->outputFile);
     }
 
+    public function testCoverageWritesHtmlReportWithCustomBounds()
+    {
+        $this->outputFile = 'html/index.html';
+        $this->assertOutputDirectoryNotExists();
+
+        $input = new ArgvInput(
+            [
+                'coverage',
+                $this->logDirectory . 'coverage/',
+                '--html=' . $this->logDirectory . dirname($this->outputFile),
+                '--lowUpperBound=20',
+                '--highLowerBound=70',
+            ]
+        );
+        $output = $this->prophesize(OutputInterface::class);
+        $output->write(Argument::type('string'))->shouldBeCalled();
+
+        $command = new CoverageCommand();
+        $command->run($input, $output->reveal());
+
+        $this->assertFileExists($this->logDirectory . $this->outputFile);
+    }
+
     public function testCoverageWritesOutputFileAndHtmlReport()
     {
         $this->outputFile = 'html/coverage.xml';