Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Madtheme: add chapter fetching preferences #7270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dngonz
Copy link
Contributor

@dngonz dngonz commented Jan 20, 2025

Closes #7268

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@dngonz dngonz changed the title Madtheme: add fetching preferences Madtheme: add chapter fetching preferences Jan 20, 2025
@vetleledaal
Copy link
Contributor

Seems like the wrong abstraction layer? Is this something that is better scoped for each site? Or entry? Is the only way to check definitely by testing both endpoints?

Also, from the user's point of view this is an implementation detail that is hard to take a position on.

@dngonz
Copy link
Contributor Author

dngonz commented Jan 21, 2025

Is this something that is better scoped for each site? Or entry?

Either I think, I didn't test it too much but depends on the site and/or entry, there are some site that the updated chapter list is by Id and others are by slug

Is the only way to check definitely by testing both endpoints?

Yes I think so, the original issue #3976 in this case 4 Cut Hero uses the slug fetch and the chapter entries are all wrong but with the id fetch has the real entries.
By other hand in this issue Demon King Who Lost His Job if you search by slug has a more updated chapter list than by id.
Also if you notice on the entry site Demon King Who Lost His Job if you press "Show More", bellow chapters, the list will change by the id fetch, basically the API is not really in sync.

Also, from the user's point of view this is an implementation detail that is hard to take a position on.

I could add a new option that includes both, that will compare the two requests and choose the one with more chapters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MangaBuddy not fetching some chapters
2 participants