Dependencies for CITS SIARD #303
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|242 col 76| Parameter zipEntries should be final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|242 col 102| Variable 'zipEntries' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|243 col 5| Parameter representationMETSWrapper should be final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|243 col 17| Variable 'representationMETSWrapper' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|243 col 44| Parameter representation should be final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|243 col 61| Variable 'representation' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|243 col 77| Parameter representationId should be final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|243 col 84| Variable 'representationId' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|257 col 20| Variable 'fileType' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|259| Line is longer than 120 characters (found 156).
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|265 col 61| Unnecessary parentheses around expression.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKSIP.java|207 col 19| Variable 'mainMETSWrapper' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKSIP.java|210 col 89| The String " " appears 2 times in the file.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|61| Line is longer than 120 characters (found 121).
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|61 col 3| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|61 col 22| More than 7 parameters (found 17).
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|62| Line is longer than 120 characters (found 138).
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|63| Line is longer than 120 characters (found 147).
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|64| Line is longer than 120 characters (found 148).
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|65| Line is longer than 120 characters (found 124).
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|88 col 9| Unnecessary parentheses around expression.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|303 col 3| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKMETSCreator.java|331| Line is longer than 120 characters (found 150).
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 11| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 27| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 35| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 43| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 52| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 61| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 68| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 75| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29| Line is longer than 120 characters (found 127).
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 27| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 49| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 69| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 105| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 10| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 15| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 20| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 13| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 20| Missing a Javadoc comment.
| @@ -59,6 +59,21 @@ public InputStream getMetsRootInputStream(final Path path) throws FileNotFoundEx | |||
| return new FileInputStream(metsPath); | |||
| } | |||
|
|
|||
| public InputStream getErmsInputStream(final Path path) throws FileNotFoundException { | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| } | ||
| } | ||
| if (ermsPath == null) { | ||
| LOGGER.debug("ERMS.xml not Found"); |
There was a problem hiding this comment.
The String "ERMS.xml not Found" appears 2 times in the file.
| * @throws IOException | ||
| * if some I/O error occurs | ||
| */ | ||
| public InputStream getErmsInputStream(Path path) throws IOException { |
There was a problem hiding this comment.
Parameter path should be final.
| * @throws IOException | ||
| * if some I/O error occurs | ||
| */ | ||
| public InputStream getErmsInputStream(Path path) throws IOException { |
There was a problem hiding this comment.
Variable 'path' should be declared final.
| zipFile = new ZipFile(path.toFile()); | ||
| } | ||
|
|
||
| Enumeration entries = zipFile.entries(); |
There was a problem hiding this comment.
Variable 'entries' should be declared final.
| @@ -91,6 +91,15 @@ | |||
| } | |||
| } | |||
|
|
|||
| public static void addRepresentationGroupsToErmsSIP(SIP sip, final List<RepresentationGroup> representationGroups, | |||
| boolean targetOnly) throws IPException { | |||
There was a problem hiding this comment.
Variable 'targetOnly' should be declared final.
| @@ -38,6 +38,7 @@ | |||
| import org.roda_project.commons_ip2.mets_v1_12.beans.StructMapType; | |||
| import org.roda_project.commons_ip2.model.AIP; | |||
| import org.roda_project.commons_ip2.model.IPConstants; | |||
| import org.roda_project.commons_ip2.model.IPContentInformationType; | |||
There was a problem hiding this comment.
Unused import - org.roda_project.commons_ip2.model.IPContentInformationType.
| @@ -62,6 +63,8 @@ | |||
|
|
|||
| import jakarta.xml.bind.JAXBException; | |||
|
|
|||
| import javax.xml.namespace.QName; | |||
There was a problem hiding this comment.
Wrong order for 'javax.xml.namespace.QName' import.
|
|
||
| } | ||
|
|
||
| private void addRepresentationDataFilesToZipSiardAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries, |
There was a problem hiding this comment.
Parameter ip should be final.
|
|
||
| } | ||
|
|
||
| private void addRepresentationDataFilesToZipSiardAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries, |
There was a problem hiding this comment.
Variable 'ip' should be declared final.
carlosjepard
force-pushed
the
cafonso-devSIARD
branch
from
27b515c to
d125cb4
Compare
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 68| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 75| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29| Line is longer than 120 characters (found 127).
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 27| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 49| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 69| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 105| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 10| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 15| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|12 col 20| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 13| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 20| Missing a Javadoc comment.
|
|
||
| } | ||
|
|
||
| private void addRepresentationDataFilesToZipSiardAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries, |
There was a problem hiding this comment.
Parameter zipEntries should be final.
|
|
||
| } | ||
|
|
||
| private void addRepresentationDataFilesToZipSiardAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries, |
There was a problem hiding this comment.
Variable 'zipEntries' should be declared final.
| } | ||
|
|
||
| private void addRepresentationDataFilesToZipSiardAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries, | ||
| MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId) |
There was a problem hiding this comment.
Parameter representationMETSWrapper should be final.
| } | ||
|
|
||
| private void addRepresentationDataFilesToZipSiardAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries, | ||
| MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId) |
There was a problem hiding this comment.
Variable 'representationMETSWrapper' should be declared final.
| } | ||
|
|
||
| private void addRepresentationDataFilesToZipSiardAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries, | ||
| MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId) |
There was a problem hiding this comment.
Parameter representation should be final.
| @@ -15,7 +15,7 @@ public class IPContentInformationType implements Serializable { | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER; | |||
| ERMS, citssiard_v1_0, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -15,7 +15,7 @@ public class IPContentInformationType implements Serializable { | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER; | |||
| ERMS, citssiard_v1_0, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -15,7 +15,7 @@ public class IPContentInformationType implements Serializable { | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER; | |||
| ERMS, citssiard_v1_0, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -15,7 +15,7 @@ public class IPContentInformationType implements Serializable { | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER; | |||
| ERMS, citssiard_v1_0, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -15,7 +15,7 @@ public class IPContentInformationType implements Serializable { | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER; | |||
| ERMS, citssiard_v1_0, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
carlosjepard
force-pushed
the
cafonso-devSIARD
branch
from
d125cb4 to
e2bf5a1
Compare
| mainMETSWrapper.getMets().getMetsHdr().getOAISPACKAGETYPE(), representation.getContentType(), | ||
| representation.getContentInformationType(), isRepresentationMetadata, isRepresentationMetadataOther, | ||
| isRepresentationSchemas, isRepresentationDocumentation, false, false, isRepresentationsData); | ||
| } |
There was a problem hiding this comment.
'}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
| @@ -15,7 +15,7 @@ public class IPContentInformationType implements Serializable { | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset, citssiard_v1_0; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -15,7 +15,7 @@ | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset, citssiard_v1_0; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -15,7 +15,7 @@ | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset, citssiard_v1_0; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -15,7 +15,7 @@ | |||
| private static final long serialVersionUID = 1191075605637022551L; | |||
|
|
|||
| public enum IPContentInformationTypeEnum { | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset; | |||
| ERMS, citserms_v2_1, SIARD1, SIARD2, SIARDDK, GEODATA, MIXED, OTHER, Dataset, citssiard_v1_0; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| public class IPEnums { | |||
| public enum IPType { | |||
| SIP, AIP, DIP; | |||
| SIP, AIP, DIP, SIARD; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -33,7 +33,7 @@ | |||
| } | |||
|
|
|||
| public enum SipType { | |||
| EARK2S, EARK2, ERMS | |||
| EARK2S, EARK2, SIARD, ERMS | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -33,7 +33,7 @@ | |||
| } | |||
|
|
|||
| public enum SipType { | |||
| EARK2S, EARK2, ERMS | |||
| EARK2S, EARK2, SIARD, ERMS | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -33,7 +33,7 @@ | |||
| } | |||
|
|
|||
| public enum SipType { | |||
| EARK2S, EARK2, ERMS | |||
| EARK2S, EARK2, SIARD, ERMS | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -33,7 +33,7 @@ | |||
| } | |||
|
|
|||
| public enum SipType { | |||
| EARK2S, EARK2, ERMS | |||
| EARK2S, EARK2, SIARD, ERMS | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
carlosjepard
force-pushed
the
cafonso-devSIARD
branch
from
e2bf5a1 to
68de195
Compare
No description provided.